Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stepper] Support reverse vertical stepper #21286

Open
tomlim1017 opened this issue Jun 2, 2020 · 6 comments
Open

[Stepper] Support reverse vertical stepper #21286

tomlim1017 opened this issue Jun 2, 2020 · 6 comments
Labels
component: stepper This is the name of the generic UI component, not the React module! new feature New feature or request waiting for 馃憤 Waiting for upvotes

Comments

@tomlim1017
Copy link

Current Behavior 馃槸

My issue is basically the same as the one below.

#15784

it is marked as solved but in the code sandbox the connector lines are messed up
Node 1 has a line going down while Node 2-> 3 does not have a complete connector line.

https://codesandbox.io/s/material-demo-75ehz

Expected Behavior 馃

Node 3 content now has the ".MuiStepContent-last" class which removes the border-left (connector line).

The class should be removed and be applied to Node 1, so there is no extra line below node 1

Steps to Reproduce 馃暪

https://codesandbox.io/s/material-demo-75ehz

Your Environment 馃寧

Tech Version
Material-UI v4.5.0
React
Browser Chrome

Context

I know what needs to be done to solve the issue (removing the MuiStepContent-last class etc) but i don't know how to go about accomplishing it

@tomlim1017 tomlim1017 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 2, 2020
@oliviertassinari oliviertassinari added component: stepper This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 2, 2020
@oliviertassinari oliviertassinari changed the title [Stepper] Reverse vertical stepper starting point [Stepper] Support reverse vertical stepper Jun 2, 2020
@oliviertassinari oliviertassinari added the waiting for 馃憤 Waiting for upvotes label Jun 2, 2020
@oliviertassinari
Copy link
Member

I have added the waiting for users upvotes tag. I'm closing the issue as we are not sure people are looking for such abstraction. So please upvote this issue if you are. We will prioritize our effort based on the number of upvotes.

@tomlim1017
Copy link
Author

I don't understand why this issue was closed.

It is the same issue as
#15784

but that issue was marked as closed before all the bugs were worked out.

I think wanting to reverse the starting point on a vertical stepper is a pretty common issue.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 2, 2020

You have shown how the related issue wasn't solved properly. It has transformed the request into a new feature proposal. Could you expand on your use case for a reverse stepper? :)

@tomlim1017
Copy link
Author

tomlim1017 commented Jun 2, 2020

Well the project I am working on is designed with a vertical stepper that starts from the Bottom and activates nodes based on the user's point total, to show progress.

starting at the top, in this case, doesn't really work

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 2, 2020

Do you have a visual example? I think that it could help better evaluate the potential value of the feature. Also, if you could have a look at how this can be properly implemented in the component, it would also help get it closer to the finish line :).

@tomlim1017
Copy link
Author

Screenshot from 2020-06-02 14-14-08

In the screenshot, I have reversed the stepper so it starts from the bottom.

as you can see the content at the very top node has no connector line, this is because it has the class MuiStepContent-last has the property "border-left: none"

and the very bottom node, should have MuiStepContent-last, to remove the extra connector line

I believe this is the problem:

the non reversed stepper classes look like this
MuiStepContent
MuiStepContent
MuiStepContent
MuiStepContent-last

when it is reversed it looked like
MuiStepContent-last
MuiStepContent
MuiStepContent
MuiStepContent

When it should still look like the non reversed stepper. Because we don't want the extra connector line.

MuiStepContent-last class should be applied to the bottom node content regardless of where the stepper starts

I'm relatively new to development, and this is just what I think would solve it. I don't know how to implement it though.

@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! new feature New feature or request waiting for 馃憤 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

2 participants