New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use hard tabs in the source for accessibility #22283
Comments
|
Disclosure: I started using tabs in new projects about 6 months ago. Looking back I always justified spaces with their superiority for manual formatting across environments. Using tabs just didn't work if you wanted to align your SQL queries or hardcoded data structures. But when prettier came along and I grew used to it I never re-evaluated my choice. Since we don't manually format code anymore, tabs are objectively better for a11y and most tools I'm aware of support custom tab-width I don't see a reason to use spaces anymore. |
@mbrookes If we can have a default shared configuration of two spaces for tabs, have it work in GitHub and popular text editors, this would work from my end. |
It all seems to work – I had to adjust my editor to display tabs as two spaces, but that's kind of the point! :)
|
Summary of the exploration of #22305. We are waiting for GitHub to come through to resume the changes. We need:
|
Summary 💡
Hard tabs allow contributors to choose how many spaces a tab represents, which aids accessibility.
Discussion:
rome/tools#425
Examples 🌈
https://github.com/romefrontend/rome
Motivation 🔦
Material-UI as a user interface component library has a strong accessibility ethic. This should extend to contributor DX.
The text was updated successfully, but these errors were encountered: