Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] Add test cases #22371

Open
mnajdova opened this issue Aug 26, 2020 · 5 comments
Open

[Localization] Add test cases #22371

mnajdova opened this issue Aug 26, 2020 · 5 comments
Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted test

Comments

@mnajdova
Copy link
Member

Summary 馃挕

Recently with #22293 I broke the locales, but no tests caught this. We should cover the localization with tests, so this won't happen again.
@mnajdova mnajdova added status: waiting for maintainer These issues haven't been looked at yet by a maintainer test labels Aug 26, 2020
@oliviertassinari oliviertassinari added ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 26, 2020
@Avi98
Copy link
Contributor

Avi98 commented Oct 1, 2020

hi @mnajdova , I really want to learn how tests are implemented in Material-UI. Can I take this issue

@eps1lon
Copy link
Member

eps1lon commented Oct 1, 2020

hi @mnajdova , I really want to learn how tests are implemented in Material-UI. Can I take this issue

Feel free to work on it. I'm assigning you for bookkeeping purposes only. If you decide to no longer work on this issue please leave a message so that other people can take over.

https://github.com/mui-org/material-ui/blob/next/test/README.md might be a good starting point to learn about our testing approach and infrastructure.

@Avi98
Copy link
Contributor

Avi98 commented Oct 6, 2020

hi @mnajdova, I tried to go through the pull request #22293 but could not figure out what all things I need to cover in the tests. It would be great if someone could help me understand what should be the scope of tests.

@Avi98
Copy link
Contributor

Avi98 commented Oct 7, 2020

Unassign it from me as I don't have enough clarity.

@Avi98 Avi98 removed their assignment Oct 7, 2020
@reedanders
Copy link
Contributor

hi @mnajdova, I'd like to close this up, but I would like to certain of the case where localization broke in #22293.

Can you confirm this is the failure you'd like to test for? #22293 (comment). Specifically, changing localization to https://deploy-preview-22293--material-ui.netlify.app/zh/customization/density/#main-content results in a 404 error.

@oliviertassinari oliviertassinari mentioned this issue Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oliviertassinari @mnajdova @reedanders @eps1lon @Avi98