[Material-UI v5 alpha 32] experimentalStyled missing styleProps in typescript definition

[david-ic3]

Trying to create my own component using experimentalStyled mimicking Autocomplete in typescript I got a compile error on styleProps property

<AutocompleteLoading styleProps={props}>
  This is not compiling
</AutocompleteLoading>

Property 'styleProps' does not exist on type ...

In Sandbox a simplified example https://codesandbox.io/s/interesting-babbage-zyrpz?file=/src/Demo.tsx:658-757

[mnajdova]

Thanks for the report, was fixed in #25928, will be available in the next release.

[oliviertassinari]

Could it be seen as a duplicate of #24862?

Spreading extra props might actually be something we could document in https://next--material-ui.netlify.app/guides/styled-engine/ (in addition to the existing customization page). We currently cover it in https://next--material-ui.netlify.app/customization/how-to-customize/#dynamic-css.

[mnajdova]

Yeah, makes sense. 👍

[david-ic3]

Thanks for the quick turnaround, I see I'm not the only one working on week-ends, guys really no need.

From a documentation side a bit around this experimentalStyle function would be welcomed as an example on how to create a composed component like an MUI one from scratch.

To get a hint what we are trying to achieve (selected is a new prop) :

function MyUselessButton(props: PropsOf<typeof Button> & {selected: boolean | undefined} ) {
    return <Button {...props} />;
}

const FilterButton = experimentalStyled(MyUselessButton, {
    shouldForwardProp: (prop) => prop !== 'selected',
})(({selected, theme}) => ({
    ...theme.components!['FilterButtons'].styleOverrides.muiButton,   // it's a bit of hack and we don't have variants
    ...selected && {backgoundColor: theme.live['selection'].selectedColor}
}));

my one cent

[mnajdova]

Note, in the end we decided not to include the styleProps by default, see #26461

The main motivation was that, if developers need it, they are likely going to need to specify custom type for it, so we decided to better make it explicit, rather then implicit. As the prop is not added anymore, no need for updating the docs.