Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple of outlined buttons has incorrect corner radius #26653

Open
2 tasks done
Merlin04 opened this issue Jun 8, 2021 · 2 comments
Open
2 tasks done

Ripple of outlined buttons has incorrect corner radius #26653

Merlin04 opened this issue Jun 8, 2021 · 2 comments
Assignees
Labels
component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request

Comments

@Merlin04
Copy link

Merlin04 commented Jun 8, 2021

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 馃槸

Right now, when you hold down an outlined button, there are gaps between the button ripple and the button outline due to the ripple having an incorrect radius.
Demo image

Expected Behavior 馃

When the button is held down, the ripple should fill the entire button, with no gaps between the outline and the ripple.

Steps to Reproduce 馃暪

This is visible on the documentation page: https://material-ui.com/components/buttons/#outlined-buttons

Steps:

  1. Click on an outlined button and hold it down until the ripple fills the button

Your Environment 馃寧

I've tested this on both Firefox 89 and Chromium 91.

`npx @material-ui/envinfo`
  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
  Binaries:
    Node: 14.16.0 - /usr/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.11 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 89.0
  npmPackages:
    @material-ui/core: ^4.11.4 => 4.11.4 
    @material-ui/styles:  4.11.4 
    @material-ui/system:  4.11.3 
    @material-ui/types:  5.1.0 
    @material-ui/utils:  4.11.2 
    @types/react: ^17.0.4 => 17.0.5 
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    typescript: 4.3.2 => 4.2.4 
@Merlin04 Merlin04 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 8, 2021
@mnajdova mnajdova added component: button This is the name of the generic UI component, not the React module! new feature New feature or request design: material This is about Material Design, please involve a visual or UX designer in the process and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 9, 2021
@kashishmadan
Copy link

Hi! I was able to reproduce the behavior and also similar problem happens with the Icon Buttons - (https://material-ui.com/components/buttons/#icon-buttons)
Example -
image

Can I please work on this issue? @mnajdova

@eps1lon
Copy link
Member

eps1lon commented Jun 20, 2021

@kashishmadan Thanks for the initiative. Feel free to go ahead and work on the issue. If you're stuck at any point during the Pull Request process, be sure to check out CONTRIBUTING or you can ping any of the maintainers for more guidance.

@eps1lon eps1lon added this to the v5 milestone Jun 20, 2021
@oliviertassinari oliviertassinari removed this from the v5 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants