-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TimePicker] ClockNumber has weird focus outline on Safari #26664
Comments
This comment has been minimized.
This comment has been minimized.
I'm still experimenting this issue with the mud v5 release. Do you have any clue on how to fix it? Any workaround? @watiko. I tried the
but it doesn't work |
I too am having this issue |
Any Updates on this Issue |
Add following prop to TimePicker as workaround: DialogProps={{
PaperProps: {
sx: { '& *:focus': { outline: 'none' } },
},
}} Try here: codesandbox However, since I do not know the side effects, please use with caution! |
What's the correct syntax for this workaround for a |
I get same problem in DesktopDateTimePicker but that is not have DialogProps how to do? |
@bc-m
Safari Version 15.1 |
This issue with TimePicker is still reproducible!!! |
If you are using DesktopTimePicker, you need to change on the theme for MuiPaper |
Confirmed, thanks @samanmovaghar. So is this a bug in MuiPaper then? |
Yes, exactly, this is a bug for MuiPaper, after I have changed on theme default props, the bug has been fixed on Safari @markedwards |
This code works TimePicker well. <TimePicker
{...field}
DialogProps={{
PaperProps: {
sx: { "& *:focus": { outline: "none" } },
},
}}
PopperProps={{
sx: { "& *:focus": { outline: "none" } },
}}
renderInput={(params) => ( /** ... */)}
/> my environment
|
When open a TimePicker, Safari renders weird focus outline.
I think this behavior was introduced by #26400.
Workaround
https://github.com/mui-org/material-ui/blob/a533d062df191a95478a663a9f926de4f94b3046/packages/material-ui-lab/src/ClockPicker/Clock.tsx#L270-L279
Current Behavior 😯
Chrome/Firefox
Safari
Expected Behavior 🤔
Chrome/Firefox/Safari
Steps to Reproduce 🕹
Steps:
Your Environment 🌎
The text was updated successfully, but these errors were encountered: