Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Document what and why icons are included/excluded #27168

Open
esjs opened this issue Jul 7, 2021 · 3 comments
Open

[icons] Document what and why icons are included/excluded #27168

esjs opened this issue Jul 7, 2021 · 3 comments
Labels
new feature New feature or request package: icons Specific to @mui/icons

Comments

@esjs
Copy link

esjs commented Jul 7, 2021

HI, I want to ask what is the reason for adding icons to blacklist? On Google icons website I see that they are licences under Apache license 2.0, which basically means Open Source.

I've found this issue which says something about irrelevant icons, but what is considered irrelevant and why?

I've been using both of those icons, but now they are not available anymore. Should I add them myself if I really need them?
'VerticalDistribute', // Advanced text editor
'HorizontalDistribute', // Advanced text editor

  • [ x] I have searched the issues of this repository and believe that this is not a duplicate.

Thank you,
Vladimir

@esjs esjs added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 7, 2021
@michal-perlakowski
Copy link
Contributor

As the comment says, these icons are only useful if you're creating an advanced text editor. Which means they won't be useful for the vast majority of users and including them would unnecessarily increase bundle size.

@esjs
Copy link
Author

esjs commented Jul 8, 2021

Yeah, I agree, but if you wouldn't import it then it won't be added to resulting bundle.
Seems like an unnecessary restriction for me, because still a lot of icons in MUI set if you include them all.

But still, if you think that it shouldn't be added, I can add it myself, just want to make sure that I don't add what is already available.
So I will ask again, should I add this myself if I need this, or can it be removed from blacklist?

@eps1lon
Copy link
Member

eps1lon commented Jul 13, 2021

Seems like an unnecessary restriction for me, because still a lot of icons in MUI set if you include them all.

The size of the package is already an issue since we frequently get reports of install timeouts. We don't have any standard on when icons are added or not. Would be nice to document that.

@eps1lon eps1lon added new feature New feature or request package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 13, 2021
@eps1lon eps1lon changed the title Some icons inside @material-ui/icons package are blacklisted [icons] Document what and why icons are included/excluded Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

3 participants