You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HI, I want to ask what is the reason for adding icons to blacklist? On Google icons website I see that they are licences under Apache license 2.0, which basically means Open Source.
I've found this issue which says something about irrelevant icons, but what is considered irrelevant and why?
I've been using both of those icons, but now they are not available anymore. Should I add them myself if I really need them?
'VerticalDistribute', // Advanced text editor
'HorizontalDistribute', // Advanced text editor
[ x] I have searched the issues of this repository and believe that this is not a duplicate.
Thank you,
Vladimir
The text was updated successfully, but these errors were encountered:
As the comment says, these icons are only useful if you're creating an advanced text editor. Which means they won't be useful for the vast majority of users and including them would unnecessarily increase bundle size.
Yeah, I agree, but if you wouldn't import it then it won't be added to resulting bundle.
Seems like an unnecessary restriction for me, because still a lot of icons in MUI set if you include them all.
But still, if you think that it shouldn't be added, I can add it myself, just want to make sure that I don't add what is already available.
So I will ask again, should I add this myself if I need this, or can it be removed from blacklist?
Seems like an unnecessary restriction for me, because still a lot of icons in MUI set if you include them all.
The size of the package is already an issue since we frequently get reports of install timeouts. We don't have any standard on when icons are added or not. Would be nice to document that.
eps1lon
changed the title
Some icons inside @material-ui/icons package are blacklisted
[icons] Document what and why icons are included/excluded
Jul 13, 2021
HI, I want to ask what is the reason for adding icons to blacklist? On Google icons website I see that they are licences under Apache license 2.0, which basically means Open Source.
I've found this issue which says something about irrelevant icons, but what is considered irrelevant and why?
I've been using both of those icons, but now they are not available anymore. Should I add them myself if I really need them?
'VerticalDistribute', // Advanced text editor
'HorizontalDistribute', // Advanced text editor
Thank you,
Vladimir
The text was updated successfully, but these errors were encountered: