Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Contained with inherit prop not adapting on dark mode #29749

Closed
2 tasks done
adrianmanea opened this issue Nov 18, 2021 · 1 comment 路 Fixed by #34508
Closed
2 tasks done

[Button] Contained with inherit prop not adapting on dark mode #29749

adrianmanea opened this issue Nov 18, 2021 · 1 comment 路 Fixed by #34508
Labels
bug 馃悰 Something doesn't work component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@adrianmanea
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

As mentioned by @JeremyGrieshop in another thread #28363 (comment) the contained variant with the inherit color prop does not adapt its background color.

Code sandbox by Jeremy demonstrating the issue: https://codesandbox.io/s/togglecolormode-material-demo-forked-1j544?file=/demo.js

Expected behavior 馃

Since it is using grey[300] for the light mode, maybe switching to something like grey[700] or dark mode?
image

Steps to reproduce 馃暪

Steps:

Context 馃敠

No response

Your environment 馃寧

@mui/material": "5.1.0"
@adrianmanea adrianmanea added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 18, 2021
@mbrookes mbrookes added accessibility a11y component: button This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 20, 2021
@LuigiZaccagnini
Copy link

I can take this issue!

@jesrodri jesrodri mentioned this issue Sep 28, 2022
Merged
1 task
@ZeeshanTamboli ZeeshanTamboli added bug 馃悰 Something doesn't work design: material This is about Material Design, please involve a visual or UX designer in the process and removed accessibility a11y labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 馃悰 Something doesn't work component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Button] Fix contained with inherit prop not adapting on dark mode jesrodri/material-ui
4 participants
@mbrookes @adrianmanea @ZeeshanTamboli @LuigiZaccagnini