Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skeleton] Add loading property #30407

Open
2 tasks done
locona opened this issue Dec 26, 2021 · 5 comments
Open
2 tasks done

[Skeleton] Add loading property #30407

locona opened this issue Dec 26, 2021 · 5 comments
Labels
component: skeleton This is the name of the generic UI component, not the React module! new feature New feature or request package: material-ui Specific to @mui/material

Comments

@locona
Copy link

locona commented Dec 26, 2021 •
edited by oliviertassinari

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 馃挕

Add the loading property to simplify the loading branch of the data acquisition.

Examples 馃寛

Use cases are expected to include

<Skeleton loading={loading}>
	<Children />
</Skeleton>

Motivation 馃敠

I would like to achieve the following simplification of branching.

current

{loading ? (
  <Skeleton variant="circular">
    <Avatar />
  </Skeleton>
) : (
  <Avatar src={data.avatar} />
)}

After the realization of this ISSUE

<Skeleton loading={loading} variant="circular">
  <Avatar src={data.avatar} />
</Skeleton>
@locona locona added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 26, 2021
@masterambi
Copy link

it would be nice

@ahmad-reza619

This comment was marked as off-topic.

Sign in to view
@mbrookes mbrookes changed the title [SKeleton] Add loading property [Skeleton] Add loading property Dec 26, 2021
@mbrookes mbrookes added component: skeleton This is the name of the generic UI component, not the React module! new feature New feature or request breaking change and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 26, 2021
@mnajdova

This comment was marked as resolved.

Sign in to view
@locona

This comment was marked as outdated.

Sign in to view
@oliviertassinari
Copy link
Member

@siriwatknp explored this idea in Joy UI https://deploy-preview-37893--material-ui.netlify.app/joy-ui/react-skeleton/#loading. If successful, we can roll it out Material UI as well.

@oliviertassinari oliviertassinari added package: material-ui Specific to @mui/material and removed breaking change labels Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: skeleton This is the name of the generic UI component, not the React module! new feature New feature or request package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mbrookes @oliviertassinari @mnajdova @locona @masterambi @ahmad-reza619