Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputUnstyled] not forwarding textarea specific props (rows, maxRows, minRows) #33060

Closed
2 tasks done
sum93 opened this issue Jun 7, 2022 · 0 comments 路 Fixed by #33873
Closed
2 tasks done

[InputUnstyled] not forwarding textarea specific props (rows, maxRows, minRows) #33060

sum93 opened this issue Jun 7, 2022 · 0 comments 路 Fixed by #33873
Labels
bug 馃悰 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
MUI Core public roadmap

Comments

@sum93
Copy link

sum93 commented Jun 7, 2022 •
edited

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

rows, minRows, maxRows props have no effect when the multiline flag is set for an <InputUnstyled /> component.

Expected behavior 馃

The rows, minRows, maxRows props have the same effect just as they have in the case of a <TextField /> when the multiline flag is set.

Steps to reproduce 馃暪

Steps:

  1. Use the <InputUnstyled /> component
  2. Set the multiline flag
  3. Set the rows/minRows/maxRows to any preferred value other than "2" since it's the fallback value

Context 馃敠

I was adding a multiline text input to one of the modals I'm working on and found out I cannot control the number of lines.

Your environment 馃寧

codesandbox link
@sum93 sum93 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 7, 2022
@mnajdova mnajdova added bug 馃悰 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 8, 2022
@michaldudak michaldudak changed the title InputUnstyled is not forwarding textarea specific props (rows, maxRows, minRows) [InputUnstyled] not forwarding textarea specific props (rows, maxRows, minRows) Jun 10, 2022
@siriwatknp siriwatknp mentioned this issue Aug 4, 2022
Closed
1 task
@michaldudak michaldudak mentioned this issue Aug 9, 2022
Merged
@mnajdova mnajdova added this to Q3 2022 Jul - Sep in MUI Core public roadmap Aug 10, 2022
@michaldudak michaldudak removed their assignment Oct 11, 2022
@mnajdova mnajdova moved this from Q3 2022 Jul - Sep to Done in MUI Core public roadmap Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 馃悰 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
No open projects
MUI Core public roadmap
Recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Input][base] Pass the rows prop to the underlying textarea michaldudak/material-ui
3 participants
@mnajdova @michaldudak @sum93