Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Internal link that does not exist from the Box page #33062

Closed
2 tasks done
makotot opened this issue Jun 7, 2022 · 2 comments 路 Fixed by #33149
Closed
2 tasks done

[docs] Internal link that does not exist from the Box page #33062

makotot opened this issue Jun 7, 2022 · 2 comments 路 Fixed by #33149
Labels
docs Improvements or additions to the documentation new feature New feature or request

Comments

@makotot
Copy link

makotot commented Jun 7, 2022 •
edited

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

The Box component packages all the style functions that are exposed in @mui/system.

The relevant text is above on https://mui.com/material-ui/react-box/ .

The link in this section of the Box page is probably still the same as they were in the v4 documentation and do not reflect the latest links in v5.

Expected behavior 馃

I'm new to MUI so I don't know much about it, but should https://mui.com/system/properties/ be specified as the url here 馃
@makotot makotot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 7, 2022
@oliviertassinari
Copy link
Member

馃憤 this change would make sense, thanks for raising.

@mnajdova mnajdova added new feature New feature or request docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 8, 2022
@davidgarciab davidgarciab mentioned this issue Jun 14, 2022
Merged
@davidgarciab
Copy link
Contributor

I have created #33149 to fix this, please let me know if that's fine.
Thanks!

@hzhz hzhz mentioned this issue Jun 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Fix internal link in Box page davidgarciab/material-ui
4 participants
@makotot @oliviertassinari @mnajdova @davidgarciab