Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] CssVarsProvider should not crash the app if local storage is unavailable #33853

Closed
siriwatknp opened this issue Aug 8, 2022 · 0 comments 路 Fixed by #34027
Closed

[system] CssVarsProvider should not crash the app if local storage is unavailable #33853

siriwatknp opened this issue Aug 8, 2022 · 0 comments 路 Fixed by #34027
Labels
bug 馃悰 Something doesn't work package: system Specific to @mui/system

Comments

@siriwatknp
Copy link
Member

siriwatknp commented Aug 8, 2022 •
edited by oliviertassinari
Loading

Summary 馃挕

Local storage might not be available in private mode. Pointed out by #33545 (comment).

Reference: https://github.com/mui/mui-x/blob/6be8bcbac5c6df70bf476005383df8731135f573/packages/grid/x-data-grid/src/utils/utils.ts#L13

Examples 馃寛

No response

Motivation 馃敠

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 馃悰 Something doesn't work package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[system] Catch localStorage unavailability jsakas/material-ui
2 participants
@oliviertassinari @siriwatknp