Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppBar] color prop ignored when defaultMode="dark" for CssVarsProvider #34084

Closed
2 tasks done
Nikhil1920 opened this issue Aug 26, 2022 · 0 comments 路 Fixed by #34131
Closed
2 tasks done

[AppBar] color prop ignored when defaultMode="dark" for CssVarsProvider #34084

Nikhil1920 opened this issue Aug 26, 2022 · 0 comments 路 Fixed by #34131
Assignees
@siriwatknp
Labels
bug 馃悰 Something doesn't work component: app bar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material

Comments

@Nikhil1920
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

color prop is ignored on appbar when default mode is set to dark in CssVarsProvider

Expected behavior 馃

color prop should be respected even when default mode is set to dark

Steps to reproduce 馃暪

Minimal reproduction is at https://codesandbox.io/s/material-ui-forked-84f6p7?file=/index.tsx

change the defaultMode option in line 121 to light or system to see how it should perform vs how it is performing currently

I have tested with Brave, chrome and firefox same result

Context 馃敠

No response

Your environment 馃寧

No response
@Nikhil1920 Nikhil1920 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 26, 2022
@siriwatknp siriwatknp changed the title color prop ignored when defaultMode="dark" for CssVarsProvider [AppBar] color prop ignored when defaultMode="dark" for CssVarsProvider Aug 30, 2022
@siriwatknp siriwatknp added component: app bar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material bug 馃悰 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 30, 2022
@siriwatknp siriwatknp self-assigned this Aug 30, 2022
@siriwatknp siriwatknp mentioned this issue Aug 30, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
bug 馃悰 Something doesn't work component: app bar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
2 participants
@siriwatknp @Nikhil1920