Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using linear-gradient color in theme palette #35159

Closed
2 tasks done
vimutti77 opened this issue Nov 15, 2022 · 7 comments 路 Fixed by #35178
Closed
2 tasks done

Allow using linear-gradient color in theme palette #35159

vimutti77 opened this issue Nov 15, 2022 · 7 comments 路 Fixed by #35178
Labels
docs Improvements or additions to the documentation

Comments

@vimutti77
Copy link
Contributor

vimutti77 commented Nov 15, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 馃挕

Allow using linear-gradient color in theme palette or allow to use it if it is non-default palette

Examples 馃寛

I try to use linear-gradient in palette, but I got MUI: Unsupported 'linear-gradient(-39deg, #4991f8 0%, #4bc1ff 100%)' color.
https://codesandbox.io/s/determined-fermat-mikfcs?file=/src/App.tsx

Motivation 馃敠

My client wants to use linear-gradient as one of background of button.

image

@vimutti77 vimutti77 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 15, 2022
@siriwatknp
Copy link
Member

I see that the docs are lacking this info. We should mention that the palette.*.(light|main|dark) will be used to calculate channel colors (I think this should be fixed to only apply to the default palette)

@vimutti77 to make the background works, you need to use background, not bgcolor (this is how CSS works). https://codesandbox.io/s/silent-sun-onmj8f?file=/src/App.tsx

@siriwatknp siriwatknp added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 16, 2022
@vimutti77
Copy link
Contributor Author

@siriwatknp If the channel color is an issue, Can I just specify it, so it does not need to be calculated at runtime?

However, my current approach is to use a different key customPalette instead of Palette. And using custom button to get the color from theme.

https://codesandbox.io/s/suspicious-haze-svgxrp

But I need to make sure that when a new version of @mui comes out, this approach will still work.

@siriwatknp
Copy link
Member

@vimutti77 Looks like you are trying to create a custom palette. Here is my suggestion:

  • All of the color tokens should live in colorSchemes.(light|dark).palette.* to get the benefit of the sx prop. When you write sx={{ bgcolor: 'custom.main' }}, the value will resolve correctly. This PR will fix the issue.

    However, the sx prop does not work with background yet, so you can't do this sx={{ background: 'gradient.primary' }}.

  • I think the gradient should just be color tokens and theme each component to use the gradient selectively.

    const GradientButton = ({ color = "primary" }: CustomButtonProps) => {
       return (
         <Button
           sx={{
             background: (theme) => theme.vars.palette.gradient[color].main,
             "&:hover": {
               background: (theme) => theme.vars.palette.gradient[color].dark
             }
           }}
           variant="contained"
         >
           test
         </Button>
       );
     };

@Vansh-Baghel
Copy link

@vimutti77 Looks like you are trying to create a custom palette. Here is my suggestion:

  • All of the color tokens should live in colorSchemes.(light|dark).palette.* to get the benefit of the sx prop. When you write sx={{ bgcolor: 'custom.main' }}, the value will resolve correctly. This PR will fix the issue.
    However, the sx prop does not work with background yet, so you can't do this sx={{ background: 'gradient.primary' }}.
  • I think the gradient should just be color tokens and theme each component to use the gradient selectively.
    const GradientButton = ({ color = "primary" }: CustomButtonProps) => {
       return (
         <Button
           sx={{
             background: (theme) => theme.vars.palette.gradient[color].main,
             "&:hover": {
               background: (theme) => theme.vars.palette.gradient[color].dark
             }
           }}
           variant="contained"
         >
           test
         </Button>
       );
     };

Experimental_CssVarsProvider and experimental_extendTheme didn't work for me who is using ReactJs.
I tried using it, but the site was just crashing.
Then I used createTheme and ThemeProvider, and now it works fine :

import { createTheme , Box, Typography, Button, ThemeProvider } from "@mui/material";

 const theme = createTheme({
    palette: {
      gradient: {
        main: "linear-gradient(-39deg, #4991f8 0%, #4bc1ff 100%)",
        mainChannel: "0 0 0",
        light: "linear-gradient(135deg, #4aaffd 0%, #4992f8 100%)",
        lightChannel: "0 0 0",
        dark: "linear-gradient(135deg, #4cc2ff 0%, #4aa0fa 100%)",
        darkChannel: "0 0 0",
        contrastText: "#fff",
        contrastTextChannel: "0 0 0"
      }
    }
});
const Rewards = () => {
  return (
            <ThemeProvider theme={theme}>
              <Box sx={{ width: "80%" }}>
                <Button
                  sx={{ background: (theme) => theme.palette.gradient.main }}
                  variant="determinate"
                  value={progress}
                />
              </Box>
            </ThemeProvider>
)

export default Rewards;

@siriwatknp
Copy link
Member

Experimental_CssVarsProvider and experimental_extendTheme didn't work for me who is using ReactJs.
I tried using it, but the site was just crashing.

Could you share a CodeSandbox to me so that I can take a look the error?

@Vansh-Baghel
Copy link

My bad, it is working. I was directly giving the color to the background rather than using sx. It does work.
https://codesandbox.io/s/affectionate-rui-tj5hnk?file=/src/App.js

@mpanjato-andri
Copy link

Hello all, i want to use gradient in my icon material ? is it possible ?
For example for FavoriteIcon (import FavoriteIcon from '@mui/icons-material/Favorite'), i want to use gradient its color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants