Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide: step property seems to have no effect #372

Closed
mg opened this issue Feb 25, 2015 · 3 comments
Closed

Slide: step property seems to have no effect #372

mg opened this issue Feb 25, 2015 · 3 comments
Labels
component: slider This is the name of the generic UI component, not the React module!

Comments

@mg
Copy link

mg commented Feb 25, 2015

This is probably because of this:

  _updateWithChangeEvent: function(e, percent) {
    if (this.state.percent === percent) return;
    this.setPercent(percent);
    var value = this._percentToValue(percent);
    if (this.props.onChange) this.props.onChange(e, value);
  },

For instance, a slider with min=10, max=100, step=10 does not give me 10 .. 20 .. 30 .. .. 100 but e.g.

98.07142857142857
98.39285714285714
99.03571428571429
99.35714285714286
99.67857142857143

Is this as intended?

@snorthway
Copy link
Contributor

Any progress on this?

@crenwick
Copy link
Contributor

Fix in PR #860 :)

@hai-cea
Copy link
Member

hai-cea commented Jun 18, 2015

Thanks @crenwick

@hai-cea hai-cea closed this as completed Jun 18, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: slider This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

6 participants