Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked/Unchecked toggle icon behavior consistently generates unexpected result #3805

Closed
thomasgwatson opened this issue Mar 25, 2016 · 1 comment
Labels
bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module!

Comments

@thomasgwatson
Copy link

Problem Description

The icons don't render 'properly' on the checkbox when 'checked':

When unchecked
unchecked

When checked
checked

import Checkbox from 'material-ui/lib/checkbox'
import ToggleIconLeft from 'material-ui/lib/svg-icons/hardware/keyboard-arrow-left'
import ToggleIconRight from 'material-ui/lib/svg-icons/hardware/keyboard-arrow-right'

...

<Checkbox
          label='Toggle LeftNav'
          checkedIcon={<ToggleIconLeft />}
          unCheckedIcon={<ToggleIconRight />}
          style={leftNavToggleStyle}
          onTouchTap={this.handleToggle} />

Versions

  • Material-UI: 0.14.4
  • React: 0.14
  • Browser: Chrome 48 and FF 41.0.2

I can't dig into implementation issues and do a PR right now, so going to work-around it but thought it should be flagged.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@aahan96 aahan96 added the bug 🐛 Something doesn't work label Aug 15, 2016
@oliviertassinari oliviertassinari added the component: checkbox This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

We have been porting the component on the next branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants