Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snackbar] Add multiline support #3860

Closed
treylon opened this issue Apr 2, 2016 · 4 comments
Closed

[Snackbar] Add multiline support #3860

treylon opened this issue Apr 2, 2016 · 4 comments
Labels
component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@treylon
Copy link

treylon commented Apr 2, 2016

It would be great if the Snackbar would support multiline texts. The specs for Snackbar multiline support can be found here:
https://www.google.com/design/spec/components/snackbars-toasts.html#snackbars-toasts-specs

snackbar

This feature has already been mentioned here #2826 by @mbrookes
Do you think you could fold in this little change in one of the following releases?

@mbrookes mbrookes added the new feature New feature or request label Apr 2, 2016
@mbrookes
Copy link
Member

mbrookes commented Apr 2, 2016

@treylon, @rynti, this looks like the kind of thing you should be able to tackle as a PR, since Snackbar is a relatively simple component. Feel free to give it a go if this feature is important to you.

@treylon
Copy link
Author

treylon commented Apr 2, 2016

@mbrookes I'll tackle it in the next few days :)

@mauliksoni110
Copy link

Is there any update on this?

@DesignMonkey
Copy link

DesignMonkey commented Sep 13, 2016

You can archive it with styling like

const message = 'First line\nSecond Line'

...

<Snackbar
  message={message}        
  bodyStyle={{ height: 'auto', lineHeight: '28px', padding: 24, whiteSpace: 'pre-line' }}
/>

Maybe try and set a maxHeight for mobile devices.

@oliviertassinari oliviertassinari added the component: snackbar This is the name of the generic UI component, not the React module! label Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants