Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button][joy-ui] Breaking when adding loading to Button #38672

Closed
2 tasks done
n0ir1 opened this issue Aug 27, 2023 · 1 comment 路 Fixed by #38673
Closed
2 tasks done

[Button][joy-ui] Breaking when adding loading to Button #38672

n0ir1 opened this issue Aug 27, 2023 · 1 comment 路 Fixed by #38673
Assignees
Labels
bug 馃悰 Something doesn't work component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy

Comments

@n0ir1
Copy link

n0ir1 commented Aug 27, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 馃暪

Link to live example:
https://codesandbox.io/s/priceless-smoke-c4vjkn

Steps:

  1. Open console
  2. Click on the button

Current behavior 馃槸

The Button is not disabled in the load state if the disabled props are added

Expected behavior 馃

The Button is disabled as long as it's loading. As it is written in the documentation https://mui.com/joy-ui/react-button/#loading and how it worked in the @mui/joy@5.0.0-alpha.83 version

Context 馃敠

No response

Your environment 馃寧

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.22621
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 116.0.5845.111
    Edge: Spartan (44.22621.2134.0), Chromium (116.0.1938.62)
  npmPackages:
    @emotion/react: 11.11.1 => 11.11.1
    @emotion/styled: 11.11.0 => 11.11.0
    @mui/base: 5.0.0-beta.11 => 5.0.0-beta.11
    @mui/core-downloads-tracker:  5.14.5
    @mui/joy: 5.0.0-beta.2 => 5.0.0-beta.2
    @mui/private-theming:  5.14.5
    @mui/styled-engine:  5.13.2
    @mui/system:  5.14.5
    @mui/types:  7.2.4
    @mui/utils:  5.14.5
    @types/react: 18.2.20 => 18.2.20
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: 5.1.6 => 5.1.6
@n0ir1 n0ir1 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 27, 2023
@sai6855
Copy link
Contributor

sai6855 commented Aug 27, 2023

agree that it is a bug. Opened a PR #38673

@sai6855 sai6855 added component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Aug 27, 2023
@mj12albert mj12albert removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 28, 2023
@sai6855 sai6855 added the bug 馃悰 Something doesn't work label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 Something doesn't work component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants