-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve performance (next.js) #3954
Comments
Just my 2¢... I believe having a naively written documentation site that doesn't focus itself on performance is a good thing, since much real world usage of this framework will be in non-performant sites that do the wrong thing, and to the greatest extent possible I'd suggest we should make the framework hardened to that |
@owencm for the most part I'd agree, the docs site doesn't need to be over-engineered (or shouldn't be, as you pointed out). However, this particular issue I've highlighted causes a pretty gross performance dip when you navigate the docs. The noticable delay causes bad UX at the moment -- check out the jank. |
@owencm hi, just browsing the issues here and stumble upon your comment
would you care to explain what you meant by
thanks |
@thomasmery What he's saying is, since lots of users do the wrong thing we shouldn't over-optimize the documentation in order to have it be representative of real world use so we can experience user's woes and make sure the framework can hold its ground. |
thanks, still not sure what the wrong thing is but I guess it equals to not optimized |
@thomasmery Yes, not perf optimized. |
@thomasmery yes, I meant most sites are designed badly when it comes to performance and we should ensure Material-UI is hardened to that as much as possible. For a specific example, sites often do seconds of blocking JS when buttons are clicked. We should ensure the framework is designed to ensure animations still operate correctly when that happens. I recently submitted pull request #3958 to solve this specific issue that I only discovered because our documentation site does lots of blocking JS! |
I think that we should be using next.js for that issue, that should be a game changer for UX and DX. |
Next.js provides a nice x2 improvement factor without any tweak. |
Right now the docs have pretty bad performance. This is what happens when you load pages (esp with more components):
We eventually need a documentation setup that does not involve parsing AST at runtime, it's not scalable. AST parsing for documentation purposes should all be done during the build process imo.
The text was updated successfully, but these errors were encountered: