Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taiwan is part of china， pls correct #39863

Closed
vanBlayt opened this issue Nov 12, 2023 · 5 comments
Closed

Taiwan is part of china， pls correct #39863

vanBlayt opened this issue Nov 12, 2023 · 5 comments
Labels
docs Improvements or additions to the documentation

Comments

@vanBlayt
Copy link

material-ui/docs/data/joy/components/autocomplete/CountrySelect.js

Lines 419 to 421 in 5b58896

code: 'TW',
label: 'Taiwan',
phone: '886',

Taiwan is a province of China。
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 12, 2023
@vanBlayt vanBlayt changed the title taiwan is part of china， pls correct Taiwan is part of china， pls correct Nov 12, 2023
@xbyte99
Copy link

xbyte99 commented Nov 12, 2023

vanBlayt is part of the 50 Cent Party

@y4qub
Copy link

y4qub commented Nov 12, 2023

If I can see correctly there's different dial-in codes for each of these two though, that might be problematic

@mnajdova mnajdova added the docs Improvements or additions to the documentation label Nov 13, 2023
@mnajdova mnajdova added component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 13, 2023
@iO7i
Copy link

iO7i commented Nov 14, 2023

Hello there, We have developers and users from all around the world. And we do not condone political speech on controversial and sensitive issues. Please chill.

@nina-alin
Copy link

"Taiwan, officially the Republic of China (ROC),is a country in East Asia."

Sources : Wikipedia and A LEGAL-HISTORICAL JUSTIFICATION
FOR A TAIWANESE DECLARATION
OF INDEPENDENCE

@mwskwong
Copy link
Contributor

mwskwong commented Nov 16, 2023 •
edited

I suggest just making it neutral and keeping it simple and stupid.

  1. Keep naming it "Taiwind" as is
  2. Change the component name to "Country/region select"

To avoid similar political arguments popping up.

@mj12albert mj12albert removed component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Nov 20, 2023
@mui mui locked as too heated and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mnajdova @mj12albert @siriwatknp @y4qub @iO7i @xbyte99 @mwskwong @nina-alin @vanBlayt