[system] Polish @mui/material-nextjs #40473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
remove-dead-dependency
branch
from
f7c9d9a
to
bf59c18
Compare
Netlify deploy previewhttps://deploy-preview-40473--material-ui.netlify.app/ Bundle size report |
oliviertassinari
changed the title
oliviertassinari
commented
Jan 7, 2024
| @@ -1,2 +1 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
I believe we should only "use client" where it's required. There is no client-side React API used in this module.
oliviertassinari
commented
Jan 7, 2024
| import { CacheProvider as DefaultCacheProvider } from '@emotion/react'; | ||
| import type { EmotionCache, Options as OptionsOfCreateCache } from '@emotion/cache'; |
There was a problem hiding this comment.
Duplicate import.
Yes, that is the goal. #40265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light polish on the package.
Off-topic. It feels like we should also have a
@mui/system-nextjspackage. Today, all the logic is about@mui/system. The dependency on @mui/material will only start to make sense if we have components integration. But what is there to integrate with? Link, that's it?Sure, we could also add a linear progress bar between pages, but it doesn't feel like something that should be hidden behind an npm package.