Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][ModalDialog] Fix ModalDialog layout prop override #40512

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

maakcode
Copy link
Contributor

This update fixes a type error in ModalDialog layout props that cannot be overridden with ModalDialogPropsLayoutOverrides.

closes #40331

@mui-bot
Copy link

mui-bot commented Jan 10, 2024

Netlify deploy preview

https://deploy-preview-40512--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eae81f7

@zannager zannager added component: dialog This is the name of the generic UI component, not the React module! component: modal This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 10, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript labels Jan 11, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 492dbec into mui:master Jan 11, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! component: modal This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui][ModalDialog] Cannot add or remove layouts with styleOverrides to the ModalDialog
4 participants