Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[colorManipulator] Support the oklch color notation #41728

Open
danilo-leal opened this issue Mar 31, 2024 · 1 comment
Open

[colorManipulator] Support the oklch color notation #41728

danilo-leal opened this issue Mar 31, 2024 · 1 comment
Labels
customization: theme Centered around the theming features design This is about UI or UX design, please involve a designer package: system Specific to @mui/system

Comments

@danilo-leal
Copy link
Contributor

danilo-leal commented Mar 31, 2024

Screenshot 2024-03-31 at 13 50 16

I was experimenting with converting the branding theme palette from HEX codes to the oklch() notation, but the current version of the MUI System doesn't support it, even though it does already support color(display-p3...).

I'm also a bit unsure whether this is System or Pigment CSS scope, so I'll leave that open for now.

Ultimately, this seems like the best color notation to use at the moment1, providing the same great readability that HSL has, but supporting the p3 and other color spaces. I'm super interested in converting the website & documentation to use it (and, of course, Material UI v7 should potentially use it as well). I think in the meantime I'll use color(display-3).

Search keywords: oklch, color notation, p3, wide-gamut

Footnotes

  1. https://evilmartians.com/chronicles/oklch-in-css-why-quit-rgb-hsl

@danilo-leal danilo-leal added status: waiting for maintainer These issues haven't been looked at yet by a maintainer design This is about UI or UX design, please involve a designer customization: theme Centered around the theming features labels Mar 31, 2024
@brijeshb42
Copy link
Contributor

It mainly lies in system. When fixed there, it'll automatically get fixed in Pigment.

@danilo-leal danilo-leal added package: system Specific to @mui/system and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features design This is about UI or UX design, please involve a designer package: system Specific to @mui/system
Projects
None yet
Development

No branches or pull requests

2 participants