Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icons] Add the "Id Card" icon #41853

Open
Jasermon opened this issue Apr 11, 2024 · 6 comments
Open

[icons] Add the "Id Card" icon #41853

Jasermon opened this issue Apr 11, 2024 · 6 comments
Assignees
@siriwatknp
Labels
new feature New feature or request package: icons Specific to @mui/icons

Comments

@Jasermon
Copy link

Jasermon commented Apr 11, 2024 •
edited by github-actions bot

Summary

The "id_card" icon exists in Google Symbols, but not in mui/icons-material.

https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Aid_card%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4024

Examples

image

Motivation

No response

Search keywords: id_card, card
@Jasermon Jasermon added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 11, 2024
@danilo-leal danilo-leal changed the title [mui/icons-material] Id Card Icon [icons] Add the "Id Card" icon Apr 11, 2024
@danilo-leal danilo-leal added new feature New feature or request package: icons Specific to @mui/icons labels Apr 11, 2024
@CelestialWorthy
Copy link

Thank you for your suggestion. Is there a specific case where you need an id card icon ? because the badge icon could be used as id i guess ?
image

@Jasermon
Copy link
Author

Jasermon commented Apr 15, 2024 •
edited

Thank you for your suggestion. Is there a specific case where you need an id card icon ? because the badge icon could be used as id i guess ? image

The "thing" in the top-center looks pretty bad (in my opinion ofc.) I also create customer cards in my project. When I add the badge icon it looks pretty bad.

image

This icon looks like a shopping-bag

@CelestialWorthy
Copy link

In this kind of scenarios, the badge indeed doesn't seem appropriate.
@danilo-leal @siriwatknp what do you think ?

@danilo-leal
Copy link
Contributor

Yup, it makes sense to me to add this icon. Feel free to open a PR for it!

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 16, 2024
@CelestialWorthy
Copy link

I can add this along with #41650 .

@CelestialWorthy CelestialWorthy mentioned this issue Apr 16, 2024
Closed
@danilo-leal
Copy link
Contributor

Go for it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[icons] Add the "emergency" and "id card" icons CelestialWorthy/material-ui
4 participants
@siriwatknp @Jasermon @danilo-leal @CelestialWorthy