Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Using the right to left feature with browser translators #42007

Closed
fahdmk opened this issue Apr 23, 2024 · 5 comments
Closed

[docs-infra] Using the right to left feature with browser translators #42007

fahdmk opened this issue Apr 23, 2024 · 5 comments
Labels
scope: docs-infra Specific to the docs-infra product

Comments

@fahdmk
Copy link

fahdmk commented Apr 23, 2024

Related page

https://mui.com/material-ui/getting-started/

Kind of issue

Unclear explanations

Issue description

I am aware that you have discontinued translating the docs but you left the right to left feature wich is crutial espeatilly for arab users so they can use the browser translator wich works fine despite minor buttons styling problems like this
image
so there is no need to diable these feature completely for now by making the text unreadable
image

Context

using the right to left feature in material ui v5 with browser translators

Search keywords: right to left translation

@fahdmk fahdmk added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Apr 23, 2024
@danilo-leal danilo-leal changed the title [docs] Right to left feature with browser translators [docs-infra] Using the right to left feature with browser translators Apr 23, 2024
@danilo-leal danilo-leal added the scope: docs-infra Specific to the docs-infra product label Apr 23, 2024
@danilo-leal
Copy link
Contributor

so there is no need to diable these feature completely for now by making the text unreadable

Hey @fahdmk, thanks for the issue! Just so I can clarify it — what do you mean by "no need to disable this feature"? Which one exactly? It doesn't seem like the RTL feature is disabled, but the screenshot you attached does apparently show a bug with it.

@danilo-leal danilo-leal added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Apr 23, 2024
@fahdmk
Copy link
Author

fahdmk commented Apr 23, 2024

image
so it is a bug that the test is faint like that ? @danilo-leal

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Apr 23, 2024
@danilo-leal
Copy link
Contributor

Definitely, yeah — I don't understand why colors are being affected by the RTL config. I need to look this up! @alexfauquette any quick pointers from you right off the bat?

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 23, 2024
@alexfauquette
Copy link
Member

Because emotion adds a class before the :where that breaks the dark mode

#41803

@fahdmk The time it gets fixed, you can still use the light mode

@alexfauquette
Copy link
Member

I'm closing since it's a duplicate of #41239

@danilo-leal danilo-leal closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

No branches or pull requests

3 participants