Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change MenuItem hoverColour from the theme #4227

Closed
elisei-timofte opened this issue May 10, 2016 · 0 comments · Fixed by #5502
Closed

Cannot change MenuItem hoverColour from the theme #4227

elisei-timofte opened this issue May 10, 2016 · 0 comments · Fixed by #5502
Labels
good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@elisei-timofte
Copy link

Problem description

The MenuItem (ListItem) hoverColor is took from textColor. That's why muiTheme.menuItem.hoverColor has no effect (I couldn't find a place where menuItem.hoverColor is used, but this is another issue). I should be able to change the hover color without changing the textColour of my theme.

Steps to reproduce

Overide the menuItem.hoverColor in the muiTheme. (this has no effect)

Versions

  • Material-UI: 0.15.0-beta.2
  • React: 15.0.2
  • Browser: Chrome 50.0.2661.94
@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@bmb330 bmb330 mentioned this issue Aug 11, 2016
Closed
@aahan96 aahan96 mentioned this issue Aug 16, 2016
Closed
3 tasks
@oliviertassinari oliviertassinari added good first issue Great for first contributions. Enable to learn the contribution process. and removed in progress labels Nov 1, 2016
@oliviertassinari oliviertassinari added good first issue Great for first contributions. Enable to learn the contribution process. and removed good first issue Great for first contributions. Enable to learn the contribution process. labels Nov 1, 2016
@garrettn garrettn mentioned this issue Nov 2, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MenuItem][ListItem] Allow overriding hoverColor garrettn/material-ui
4 participants
@mbrookes @oliviertassinari @elisei-timofte @aahan96