Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Material Icons do not support Joy UI's "danger" color prop #42325

Open
NaveenEdala opened this issue May 22, 2024 · 1 comment
Open
Assignees
Labels
package: icons Specific to @mui/icons package: joy-ui Specific to @mui/joy

Comments

@NaveenEdala
Copy link

NaveenEdala commented May 22, 2024

Steps to reproduce

Link to live example:

Steps:

  1. Import any Icon from "@mui/icons-material"
  2. Import Button from "@mui/joy"
  3. Set the color prop on any Icon to "danger"

Current behavior

Type '"danger"' is not assignable to type '"primary" | "success" | "warning" | "disabled" | "action" | "inherit" | "secondary" | "error" | "info" | undefined'.

Expected behavior

Expected behavior is for the icon to inherit the red "danger" color, as is the case with all Joy components.

Context

I'm trying to use it to create simple label strings (in )

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: Icons, Icons-Material, Joy UI, Danger

@NaveenEdala NaveenEdala added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 22, 2024
@zannager zannager added the package: icons Specific to @mui/icons label May 22, 2024
@danilo-leal danilo-leal changed the title MUI Icons-Material Icons do not support Joy UI's "danger" color property [icons] Material Icons do not support Joy UI's "danger" color prop May 22, 2024
@danilo-leal danilo-leal added the package: joy-ui Specific to @mui/joy label May 22, 2024
@danilo-leal
Copy link
Contributor

Heya @NaveenEdala, thanks for the issue! I see that's an issue, but I'd expect to have some way to map Joy's danger prop to Material's error prop instead of the Material Icons package, also accounting for something that's not Material Design. @siriwatknp any ideas there? I'm not sure we should focus on this too much, too, though.

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons package: joy-ui Specific to @mui/joy
Projects
None yet
Development

No branches or pull requests

4 participants