Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Avoid cryptic errors when tests don't exist #42356

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 23, 2024

When tests are missing, reactApi.inheritance remains undefined. The existence checks for this property only checks for null values. This leads to cryptic error messages. The missing test case is expected and shouldn't block the script from running. I'm adding a warning for this. I'm also initializing the reactApi.inheritance to null and loosening the existence check, there doesn't seem to be reason to only check for null values

@Janpot Janpot added the scope: docs-infra Specific to the docs-infra product label May 23, 2024
@mui-bot
Copy link

mui-bot commented May 23, 2024

Netlify deploy preview

https://deploy-preview-42356--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7886e9b

@Janpot Janpot marked this pull request as ready for review May 23, 2024 13:25
@Janpot Janpot requested a review from a team May 23, 2024 13:27
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Janpot Janpot merged commit e7604d2 into mui:next May 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants