Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use act from react #42414

Closed
wants to merge 1 commit into from

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented May 27, 2024

No description provided.

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label May 27, 2024
@LukasTy LukasTy self-assigned this May 27, 2024
@mui-bot
Copy link

mui-bot commented May 27, 2024

Netlify deploy preview

https://deploy-preview-42414--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ef0e3c6

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@LukasTy LukasTy closed this Jun 3, 2024
@LukasTy LukasTy deleted the use-react-act-when-available branch June 3, 2024 09:18
@cherniavskii
Copy link
Member

@LukasTy Why did you close it? It's blocking mui/mui-x#12295

@cherniavskii
Copy link
Member

@LukasTy Nevermind, I guess it's because #42447 removes the createMount altogether 👍🏻

@LukasTy
Copy link
Member Author

LukasTy commented Jun 5, 2024

Nevermind, I guess it's because #42447 removes the createMount altogether 👍🏻

@cherniavskii You are correct. That was my exploration trying to keep the tests as is, but replacing enzyme with other imports.
It proved too problematic. 🙈

@LukasTy LukasTy removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024
@LukasTy
Copy link
Member Author

LukasTy commented Jun 18, 2024

@DiegoAndai is createMount here to stay for the remaining tests in material-ui?
Maybe in that case this PR makes sense? 🤔

@aarongarciah
Copy link
Member

@LukasTy we're working on removing createMount.

@LukasTy
Copy link
Member Author

LukasTy commented Jun 18, 2024

Thanks for the clarification @aarongarciah. 👍

@aarongarciah
Copy link
Member

And I think we'll update all act and other imports in #42047

@aarongarciah
Copy link
Member

@LukasTy since we're trying to remove createMount, is that ok for the X team or do you prefer that we keep it as deprecated?

@LukasTy
Copy link
Member Author

LukasTy commented Jun 19, 2024

@aarongarciah We are not using it anywhere, no objections to removing it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants