Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Drawer] can't set drawer root element #42556

Closed
tjx666 opened this issue Jun 7, 2024 · 2 comments
Closed

[material-ui][Drawer] can't set drawer root element #42556

tjx666 opened this issue Jun 7, 2024 · 2 comments
Labels
component: drawer This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material

Comments

@tjx666
Copy link

tjx666 commented Jun 7, 2024

Steps to reproduce

oneline playground: https://stackblitz.com/edit/react-hyeb7b?file=Demo.tsx

Current behavior

is still div element

Expected behavior

should be aside element

Context

I want the drawer to be a aisde elemnt and be more friendly to seo

Your environment

npx @mui/envinfo
  System:
    OS: macOS 14.5
  Binaries:
    Node: 18.20.2 - ~/.local/state/fnm_multishells/51625_1717746137681/bin/node
    npm: 10.8.0 - ~/.local/state/fnm_multishells/51625_1717746137681/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 125.0.6422.142
    Edge: Not Found
    Safari: 17.5
  npmPackages:
    @emotion/react: ^11.11.4 => 11.11.4 
    @emotion/styled: ^11.11.5 => 11.11.5 
    @mui/base:  5.0.0-beta.40 
    @mui/core-downloads-tracker:  5.15.19 
    @mui/icons-material: ^5.15.19 => 5.15.19 
    @mui/lab: 5.0.0-alpha.170 => 5.0.0-alpha.170 
    @mui/material: ^5.15.19 => 5.15.19 
    @mui/material-nextjs: ^5.15.11 => 5.15.11 
    @mui/private-theming:  5.15.14 
    @mui/styled-engine:  5.15.14 
    @mui/system: 5.15.15 => 5.15.15 
    @mui/types:  7.2.14 
    @mui/utils:  5.15.14 
    @mui/x-date-pickers: ^7.6.0 => 7.6.0 
    @mui/x-tree-view: ^6.17.0 => 6.17.0 
    @types/react: ^18.3.3 => 18.3.3 
    react: 18.2.0 => 18.2.0 
    react-dom: 18.3.1 => 18.3.1 
    typescript: ~5.4.5 => 5.4.5

Search keywords: drawer, root, aside, nav

@tjx666 tjx666 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 7, 2024
@zannager zannager added the component: drawer This is the name of the generic UI component, not the React module! label Jun 7, 2024
@tjx666
Copy link
Author

tjx666 commented Jun 8, 2024

I find temporary drawer work but persistent not

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jun 23, 2024

As stated in the docs here:

The props of the Modal component are available when variant="temporary" is set.

The component prop is the prop of the Modal component which is available only when Drawer variant is temporary.

@ZeeshanTamboli ZeeshanTamboli added package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title can't set drawer root element [material-ui][Drawer] can't set drawer root element Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

4 participants