Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] Allow chosenRequestText to be passed as a prop #4428

Closed
mwildehahn opened this issue Jun 5, 2016 · 1 comment
Closed

[AutoComplete] Allow chosenRequestText to be passed as a prop #4428

mwildehahn opened this issue Jun 5, 2016 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@mwildehahn
Copy link

Description

Somewhat related to:
#4241
#2615

I don't want the AutoComplete field to persist the text value from whatever was selected. I display Chips after the user has selected something using the AutoComplete component. After a value is selected, I want the AutoComplete value to be cleared.

I was setting the value to an empty string in onNewRequest but then this is overridden by chosenRequestText.

I propose that we add a getChosenRequestText function that can be passed as a property, the default value can be the current chosenRequestText function. This keeps the existing functionality as well as allows someone like me to pass in a function that always returns an empty string.

@oliviertassinari
Copy link
Member

I don't want the AutoComplete field to persist the text value from whatever was selected.

I'm migrating the conversation to #2615 as I believe it's the root of the issue.
Thanks for raising it.

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants