Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies restriction on react@0.13 #448

Closed
gobwas opened this issue Mar 20, 2015 · 8 comments
Closed

Peer dependencies restriction on react@0.13 #448

gobwas opened this issue Mar 20, 2015 · 8 comments
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation

Comments

@gobwas
Copy link

gobwas commented Mar 20, 2015

Hello! Im using react@0.13 in my app, and want to include your framework, but npm install ... does not allow me to =(

Can you update package.json if there will no issues on compatibility?

@badsyntax
Copy link

+1 material-ui 0.7.1 seems to work fine with react 0.13.1.

@bblumberg
Copy link

I am using material-ui 0.7.1 with react 0.13.1. and getting a "
Uncaught TypeError: Cannot read property 'replace' of undefined" from getDomId:" on radio button groups and toggles.

@irium
Copy link

irium commented Mar 23, 2015

@bblumberg +1 I'm too getting this error.

@rakeshkatti
Copy link

Even I am having this issue.

@rakeshkatti
Copy link

@bblumberg and @irium RadioButtons, TextField and many other components expect you to send "id". If you fail to send one, you will face this issue.

Documentation is not clear on this.

@irium
Copy link

irium commented Mar 26, 2015

Documentation is not clear on this.

Yeah, this should be mentioned somewhere.

For now, I've changed the dom-idable.js mixin to

getDomId: function() {
  return 'dom_id' + this._reactInternalInstance._rootNodeID.replace(/\./g, '_');
}

This seems working now.

@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 27, 2015

Thanks for finding a solution @irium! This issue was caused by React's v0.13 breaking change that removed access to this._rootNodeId. I am currently in the process of updating mui to fix all breaking changes and deprecations from our peer dependencies. It will be pushed shortly.

@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 28, 2015

v0.7.2 has just been pushed to npm! Thank you for your patience. I'm closing this issue for now. If you are still experiencing installation issues, please open up a new issue and let me know.

@mmrtnz mmrtnz closed this as completed Mar 28, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

8 participants