Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] No way to set the underlying TextField Style #4556

Closed
jeanblanchard opened this issue Jun 23, 2016 · 6 comments
Closed

[AutoComplete] No way to set the underlying TextField Style #4556

jeanblanchard opened this issue Jun 23, 2016 · 6 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@jeanblanchard
Copy link

Problem description

There is currently to way to set the style of the underlying TextField in the AutoComplete component. So no setting the font size and so on.

Suggestions:

  • Add a new textFieldStyle to the AutoComplete props and pass that as the TextField style prop
  • Forward the style prop directly to the TextField - This makes it trivial to convert a TextField to an AutoComplete, but I'm not sure about the side-effects, it's probably not such a good idea...

Versions

  • Material-UI: 0.15.1
  • React: 15.1.0
@jeanblanchard jeanblanchard changed the title [AutoComplete] No way to the the underlying TextField Style [AutoComplete] No way to set the underlying TextField Style Jun 23, 2016
@LeeKevin
Copy link

It would be helpful to also be able to style all the same components as in the TextField (e.g. the underline, hintText, etc.)

@oshalygin
Copy link

oshalygin commented Jan 10, 2017

Yeah if we can set the global style in maybe the getMuiTheme function that would be ideal. It would be nice to set the styling for common components such as TextField at the global level and then customize it accordingly when needed.

I guess the solution to that could always be our own wrapper over TextField but that seems a bit cumbersome.

@mj-airwallex
Copy link

This seems fixed, perhaps OK to close? 4bea5dd#diff-f5a0978e337757ac80c1a1dd2072e1e8

@jeanblanchard
Copy link
Author

Indeed. It seems to be fixed in v0.16.

@lechup
Copy link

lechup commented Feb 23, 2017

As far as I can see there is still no way to override all TextField styles from within AutoComplete , what I see missing:

  • floatingLabelFocusStyle
  • floatingLabelShrinkStyle
  • floatingLabelStyle
  • hintStyle
  • inputStyle
  • textareaStyle
  • underlineDisabledStyle
  • underlineFocusStyle
  • underlineStyle

@lechup
Copy link

lechup commented Feb 24, 2017

I've created #6231 to fix that...

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

6 participants