Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot put IconMenu inside of FloatingActionButton #4889

Closed
ben-pr-p opened this issue Aug 3, 2016 · 1 comment
Closed

Cannot put IconMenu inside of FloatingActionButton #4889

ben-pr-p opened this issue Aug 3, 2016 · 1 comment
Labels
component: button This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! package: icons Specific to @mui/icons

Comments

@ben-pr-p
Copy link

ben-pr-p commented Aug 3, 2016

Problem description

Icon Menu's inside of FloatingActionButtons cannot open

Steps to reproduce

        <FloatingActionButton className='floating-button' style={{left: 'auto', right: 20}} >
          <IconMenu
            iconButtonElement={
              <IconButton>
                <AccountBox/>
              </IconButton>
            }
            targetOrigin={{horizontal: 'right', vertical: 'bottom'}}
            anchorOrigin={{horizontal: 'right', vertical: 'bottom'}}
          >
            <MenuItem primaryText='Edit Me' onClick={this.editUser.bind(this)} />
            <MenuItem primateText='See Users' onClick={this.seeUsers.bind(this)} />
          </IconMenu>
        </FloatingActionButton>

Versions

  • Browser: Firefox
@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari
Copy link
Member

We have been removing the IconMenu component on the v1-beta branch. We are now encouraging people to use lower level components: the IconButton and Menu component:

juil -29-2017 19-54-51

  return (
      <div>
        <IconButton
          aria-label="More"
          aria-owns="long-menu"
          aria-haspopup="true"
          onClick={this.handleClick}
        >
          <MoreVertIcon />
        </IconButton>
        <Menu
          id="long-menu"
          anchorEl={this.state.anchorEl}
          open={this.state.open}
          onRequestClose={this.handleRequestClose}
          style={{ maxHeight: ITEM_HEIGHT * 4.5 }}
          MenuListProps={{
            style: {
              width: 200,
            },
          }}
        >
          {options.map(option =>
            <MenuItem key={option} selected={option === 'Pyxis'} onClick={this.handleRequestClose}>
              {option}
            </MenuItem>,
          )}
        </Menu>
      </div>
    );

Hence, I'm closing it. Still, we will accept PR fixes until v1-beta takes over the master branch.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: menu This is the name of the generic UI component, not the React module! component: button This is the name of the generic UI component, not the React module! package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

3 participants