Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple style bug on button components #496

Closed
mmrtnz opened this issue Apr 1, 2015 · 8 comments
Closed

Ripple style bug on button components #496

mmrtnz opened this issue Apr 1, 2015 · 8 comments
Labels
component: button This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@mmrtnz
Copy link
Contributor

mmrtnz commented Apr 1, 2015

This was brought up by @totopia. I am creating this issue so that I don't forget about it. Here was the post:

just trying to set up material-ui now, seeing a lot of errors with basic buttons
Screenshot
is that due to autoprefixer in build pipeline?

If anyone else is experience this issue, please what browser you are using. I believe this is specific to mobile. However I am not entirely sure.

@totopia, can you repost your screenshot here like you did in gitter? I only seem to be able to link to it.

@totopia
Copy link

totopia commented Apr 1, 2015

@mmrtnz https://www.dropbox.com/s/xc5xibgwpvva2cn/Screen%20Shot%202015-03-23%20at%205.27.49%20PM.png?dl=0

I resolved this by doing gulp-autoprefixer correctly with gulp-compass (a build pipeline issue)
The impacted browser is Safari on both Desktop and iOS but this bug is not related to material-ui codebase so you can close the issue.

@seubert
Copy link

seubert commented Apr 1, 2015

I have seen this on iOS in Chrome and Safari. I have not found a fix.

@troutowicz
Copy link
Contributor

I am experiencing this in mobile browsers and OSX Safari. I use webpack and it's less loader.

@FirstZero
Copy link

I would already be happy if I would get some ripple effects..
Im on firefox Linux.

@bparadie
Copy link

bparadie commented Apr 6, 2015

@totopia Thanks for pointing out your autoprefixer workaround! I use grunt and was able to fix this problem using grunt-autoprefixer. There is one remaining bug: No cursor in empty TextField w/t Floating Label Text in Safari 8.0.3, see #503

@troutowicz
Copy link
Contributor

autoprefixer fixed this this for me as well, thanks @totopia

@payner35
Copy link

payner35 commented May 3, 2015

found that there is an issue with the gulp-sourcemaps... this works for me.

gulp.task('less', function() {
  return gulp.src(path.LESS)
      //.pipe(sourcemaps.init())
      .pipe(less({
        plugins: [autoprefix, cleancss]
      }))
      //.pipe(sourcemaps.write())
      .pipe(gulp.dest(path.COMPILED_CSS));
});

@hai-cea
Copy link
Member

hai-cea commented Jun 18, 2015

This has been fixed since we're doing styles in line now.

@hai-cea hai-cea closed this as completed Jun 18, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: button This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

No branches or pull requests

10 participants