Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IconButton] Is not theme-able and the default is off spec #5190

Closed
oisinlavery opened this issue Sep 15, 2016 · 1 comment
Closed

[IconButton] Is not theme-able and the default is off spec #5190

oisinlavery opened this issue Sep 15, 2016 · 1 comment
Labels
bug 🐛 Something doesn't work component: icon button This is the name of the generic UI component, not the React module!

Comments

@oisinlavery
Copy link

Problem description

IconButton is not fully theme-able.

https://github.com/callemall/material-ui/blob/master/src/IconButton/IconButton.js#L19

The padding, width and height are hardcoded to baseTheme.spacing.iconSize * 2
Assuming a size 24px icon this makes IconButton 48x48 by default.

This is off Google Material Design spec, IconButtons should have a 24px icon with 8px padding, giving an IconButton size of 40x40.

Angular Material and Polymer are correctly set to 40x40. In general Polymer is generally closest to being on spec.

Steps to reproduce

Versions

  • Material-UI: 0.15.4
  • React: 15.3.0
  • Browser: n/a
@oisinlavery
Copy link
Author

@oliviertassinari can this be labelled as a Material Design spec issue?

@oliviertassinari oliviertassinari changed the title IconButton is not theme-able and the default is off spec [IconButton] Is not theme-able and the default is off spec May 21, 2017
@oliviertassinari oliviertassinari added component: icon button This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: icon button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants