Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle jsx and react-tools as dev-dependencies #616

Closed
mderazon opened this issue May 8, 2015 · 2 comments
Closed

bundle jsx and react-tools as dev-dependencies #616

mderazon opened this issue May 8, 2015 · 2 comments
Labels
docs Improvements or additions to the documentation

Comments

@mderazon
Copy link

mderazon commented May 8, 2015

running

$ npm run build

relies on the user to have jsx and react-tools installed globally.

IMO it's much better to bundle them locally in package.json.
This way the command will run without any external dependencies.

@hai-cea
Copy link
Member

hai-cea commented May 11, 2015

@mderazon I show react-tools is a dev-dependency in the package.json?

https://github.com/callemall/material-ui/blob/master/package.json#L40

@mderazon
Copy link
Author

My bad, you're right.

For some reason, it didn't build when I tried it. Tried it again and it seems fime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants