Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breakpoints] Extra-small defined as 360px, excludes devices in MD Device Metrics guide #6505

Closed
kgregory opened this issue Apr 5, 2017 · 1 comment
Labels
bug 🐛 Something doesn't work

Comments

@kgregory
Copy link
Member

kgregory commented Apr 5, 2017

First, let me commend the team on the work that has been put into the next branch. It is fantastic and your effort is greatly appreciated, so thank you.

The extra-small break point starts at 360px (as defined in /src/styles/breakpoints.js), which excludes several devices on the Material Design Device Metrics list. Granted, theses excluded devices are watches and some older phones, but I think the definition of extra-small should follow the guide presented in the Responsive UI - Breakpoints section of Material Design and start at 0px.

Using JSS, the only way to style something smaller than extra-small is to use:

    [theme.breakpoints.down('sm')]: { ... },

There is a problem with using this approach, which was logged in issue #6503 and PR #6504

The following rule no longer applies to any viewport smaller than 360px:

    [theme.breakpoints.only('xs')]: { ... }

We could add two rules to cover all extra-small devices, but it seems unnecessary:

   [theme.breakpoints.only('xs')]: { ... }
   [theme.breakpoints.down('xs')]: { ... }

I think extra-small should represent the smallest viewports and start at 0px.

Seems like a quick enough fix, if you would like me to submit a PR, it would be no trouble. Thanks!

@kgregory kgregory changed the title Extra-small breakpoint defined as 360, excludes many devices in MD Device Metrics guide Extra-small breakpoint defined as 360, excludes devices in MD Device Metrics guide Apr 5, 2017
@kgregory kgregory changed the title Extra-small breakpoint defined as 360, excludes devices in MD Device Metrics guide [breakpoints] Extra-small defined as 360px, excludes devices in MD Device Metrics guide Apr 5, 2017
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Nov 11, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 11, 2017

@kgregory Good catch! It was fixed in #9078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

2 participants