Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapidly pressing paper-buttons selects the label text #8

Closed
alexanderjeurissen opened this issue Oct 18, 2014 · 1 comment
Closed
Labels
component: button This is the name of the generic UI component, not the React module! component: Paper This is the name of the generic UI component, not the React module!

Comments

@alexanderjeurissen
Copy link

I noticed this when testing the ripple effect of the paper-buttons. Double-clicking the button results in the inner label text getting selected.

screenshot:
screen shot 2014-10-18 at 18 23 42

This is quite ugly, one way to prevent this from happening is adding some css to the inner label:
All of the correct CSS variations are:

.noselect {
    -webkit-touch-callout: none;
    -webkit-user-select: none;
    -khtml-user-select: none;
    -moz-user-select: none;
    -ms-user-select: none;
    user-select: none;
}

Buttons is one place where this is happening, This can be reproduced on your github.io page as well. Toolbar buttons also have this problem.

@hai-cea
Copy link
Member

hai-cea commented Oct 20, 2014

Thanks for reporting the issue. I added styles to fix this for buttons and icons.

patrykkopycinski pushed a commit to Syncano/material-ui that referenced this issue Sep 22, 2015
DavidNgv added a commit to DavidNgv/material-ui that referenced this issue Dec 8, 2016
oliviertassinari referenced this issue in oliviertassinari/material-ui Dec 2, 2017
`s/npm run/yarn/g`
oliviertassinari pushed a commit that referenced this issue Dec 5, 2017
`s/npm run/yarn/g`
mbrookes pushed a commit to mbrookes/material-ui that referenced this issue Nov 11, 2020
Move picker sources into lab (#4)

Update README.md

[DatePicker] Refactor pickers tests to testing-library and mocha (#5)

[TimePicker] Migrate tests to testing library (mui#8)

[DateTimePicker] Migrate tests  (mui#9)

Fix all pickers linter errors (mui#10)

Fix all circular dependencies (mui#11)

* Fix all circular dependencies

* Enable mocha eslint rules for typescript tests

[test] The last step to a green CI (mui#15)

Migrate pickers docs (mui#12)

Downgrade to withStyles for pickers sources (mui#16)

Add public api exports for pickers components (mui#17)

Consolidate component namespace and theme augmentation  (mui#18)

Describe conformance for pickers sub-components (mui#19)

Autogenerate proptypes for typescript sources  (mui#20)

Proper build output (mui#21)

Clear migration artifacts  (mui#23)

Eslint rule for lower-case test name convention  (mui#24)

DateRangePicker  (mui#25)

yarn deduplicate

Remove GridListTile

[DateTimePicker] Fix migration unit tests

Fix types

Fix typescript types migration issues

Fix yarn lerna build (mui#33)

Fix karma tests

use window.Touch for CI karma tests

Remove more outdated diff noise (mui#34)

Replace not valid formats with valid ISO strings

Try to fix CI touch tests

Skip tests if Touch events are not supported

Fix merge conflicts

Actually type-check

Fix safari tests

Remove lowercase test name rule

The casing is up to the test author.
We're not the grammar police in tests.

Fix lint

Format

Remove overzealous eslint-disable*

Debug failing tests

Better debugging

Timezones are fun

was isoString th efix?

Let's find out what's failing and then skip it

Branch for safari

Skip DateRangePicker in browsers

review

Matt's review

Co-authored-by: Matt <github@nospam.33m.co>

format

docs:i18n
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: Paper This is the name of the generic UI component, not the React module! component: button This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! component: Paper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants