Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make responsive container of pages configurable #492

Closed
Janpot opened this issue May 29, 2022 · 4 comments · Fixed by #3484
Closed

Make responsive container of pages configurable #492

Janpot opened this issue May 29, 2022 · 4 comments · Fixed by #3484
Labels

Comments

@Janpot
Copy link
Member

Janpot commented May 29, 2022

Allow for pages to stretch edge to edge, or configuration the maximum width of the fluid responsive container.

@Janpot Janpot mentioned this issue May 29, 2022
26 tasks
@prakhargupta1 prakhargupta1 added this to the backlog milestone May 31, 2022
@prakhargupta1
Copy link
Member

prakhargupta1 commented Aug 23, 2022

I assume this will allow the user to make apps responsive, will the width setting be available as a prop?
@apedroferreira @Janpot

@Janpot Janpot changed the title Page with responsive container Make responsive container of pages configurable Aug 23, 2022
@Janpot Janpot added the waiting for 👍 Waiting for upvotes label Aug 23, 2022
@Janpot
Copy link
Member Author

Janpot commented Aug 23, 2022

Currently the whole page is in a responsive container. If there is demand we can make that configurable. Converting this issue to a wait for upvotes.

@apedroferreira
Copy link
Member

apedroferreira commented Aug 23, 2022

I assume this will allow the user to make apps responsive, will the width setting be available as a prop? @apedroferreira @Janpot

The page is "responsive" right now, but we're not adjusting anything for smaller screens, which means probably nothing will look very good in smaller screens yet.
I think this is a different thing but not that difficult to do, we could just add the ability to customize horizontal margins in the page, or setting a maximum width, that could work too.

@prakhargupta1 prakhargupta1 removed this from the Backlog milestone Aug 29, 2022
@Janpot Janpot added the duplicate This issue or pull request already exists label Feb 22, 2023
@Janpot

This comment was marked as outdated.

@Janpot Janpot marked this as a duplicate of #1183 Feb 22, 2023
@Janpot Janpot closed this as completed Feb 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@Janpot Janpot reopened this Jun 20, 2023
@Janpot Janpot removed the duplicate This issue or pull request already exists label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants