[pickers] Popper touch the edge

[oliviertassinari]

Steps to reproduce 🕹

Link to live example:

Steps:

1. Open https://codesandbox.io/s/falling-bush-pdrn2j?file=/demo.tsx

Current behavior 😯

The PickersPopper open on the very edge.

Expected behavior 🤔

Leave a space with the edge

Context 🔦

I first observed this at https://flights.teamout.com/

would it feel much better with some padding?

cc @lildesert

Your environment 🌎

v6.11.1

Order ID or Support key 💳 (optional)

No response

[oliviertassinari]

I think we depends on a fix in Base UI: mui/base-ui#39.

[LukasTy]

I've looked into this case and it seems that having a popper modifier is quite a tricky way to achieve such behavior.
What do you think about simply adding a horizontal margin to the popper Paper instead? 🤔
Could be tested by adding the follow snippet to your demo.

slotProps={{
  desktopPaper: {
    sx: {
      mx: 1
    }
  }
}}

[oliviertassinari]

What do you think about simply adding a horizontal margin to the popper Paper instead? 🤔

This also shifts the anchor point no?
I tried this with the Material UI Tooltip mui/base-ui#413, doesn't work.

[LukasTy]

This also shifts the anchor point no?

Doesn't seem to shift it in the pickers case. 🤔

Screen.Recording.2023-08-14.at.15.33.30.mov

[oliviertassinari]

You would need to test with a placement like bottom-start, it won't be seen when centered.

For example, here we see it's 2px off https://mui.com/material-ui/react-tooltip/#positioned-tooltips

[LukasTy]

Thanks for pointing it out.
Indeed, it's not a problem only when center placement is used.
In any case, wouldn't we expect that if this is implemented via @mui/base then it would have our preferred default (probably 8px) and would implicitly resolve this issue at the same time? 🤔

[oliviertassinari]

In any case, wouldn't we expect that if this is implemented via @mui/base then it would have our preferred default (probably 8px) and would implicitly resolve this issue at the same time? 🤔

@LukasTy Oh, yeah, we could do this. It would fix this issue at the same time. But it depends on what default value we go with. If it's 4px to cover the tooltip use case, it won't be enough.