Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Add inline node name editing #10112

Open
bharatkashyap opened this issue Aug 22, 2023 · 4 comments
Open

[TreeView] Add inline node name editing #10112

bharatkashyap opened this issue Aug 22, 2023 · 4 comments
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@bharatkashyap
Copy link
Member

bharatkashyap commented Aug 22, 2023

Summary 馃挕

A tree item would be able to be renamed inline, through a double-click-to-edit workflow (possibly).

Examples 馃寛

  • Toolpad
Screen.Recording.2023-08-22.at.5.16.47.PM.mov
@bharatkashyap bharatkashyap added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 22, 2023
@bharatkashyap bharatkashyap changed the title Add inline node name editing [TreeView] Add inline node name editing Aug 22, 2023
@bharatkashyap bharatkashyap added new feature New feature or request component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Aug 22, 2023
@noraleonte noraleonte removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 23, 2023
@flaviendelangle
Copy link
Member

flaviendelangle commented Aug 24, 2023

I'm wondering if editing is compatible with the current DOM API (passing the children as components instead of passing a prop with an array of objects like the rows on the datagrid.
But we will probably have the same problem with virtualization anyway.

So the first step is probably to change the API to something like <TreeView items={[...]} />
Which is a MASSIVE breaking change and will reduce a lot the customizability of the component...

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature and removed new feature New feature or request labels Dec 1, 2023
@oliviertassinari
Copy link
Member

@bharatkashyap Do you need this feature to be built-in or where you looking for an example. I wonder if an example could be simple enough for developers.

@bharatkashyap
Copy link
Member Author

@bharatkashyap Do you need this feature to be built-in or where you looking for an example. I wonder if an example could be simple enough for developers.

Agree, perhaps an example is sufficient enough instead of supporting APIs to do this out of the box

@flaviendelangle
Copy link
Member

We discussed this with Jose yesterday
We will try to do a recipe first and we'll see if it's viable 馃憤

@joserodolfofreitas joserodolfofreitas added this to Next in queue in MUI X public roadmap Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
Development

No branches or pull requests

4 participants