Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Add support for Joy UI #11118

Open
oliviertassinari opened this issue Nov 21, 2023 · 5 comments
Open

[data grid] Add support for Joy UI #11118

oliviertassinari opened this issue Nov 21, 2023 · 5 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer new feature New feature or request waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 21, 2023

Summary 💡

Allow user to easily set up a Joy design on their data grid components.

Examples of users needing this

Solution exploration

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer design: joy This is about Joy Design, please involve a visual or UX designer in the process waiting for 👍 Waiting for upvotes design This is about UI or UX design, please involve a designer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 21, 2023
@chyzwar
Copy link

chyzwar commented Jan 31, 2024

Do you plan to work on Joy design support for mui-x v7 ? I working on new application that use joy-ui and I am trying to understand if mui-x will be viable option for DataGrid.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 1, 2024

@chyzwar there are no plans to improve Joy UI support in MUI X v7. However, it's possible to have a Joy UI data grid for you by replacing slots and restyling elements.

This workaround comes with downsides:

  1. It's time consuming
  2. The execution doesn't benefit from network effects (open source contribution polishes and fixes)
  3. Material UI stays in the bundle

Because developers can't do anything about 3. I think it's the first problem we should solve, this is #10143.

Once solved, then I think we could solve 1. and 2 by having a built-in default style layer, which this issue is about.

@chyzwar
Copy link

chyzwar commented Feb 1, 2024

Thank you for letting me know about future plans. I will go with workaround and re-style DataGrid to match joy-ui.

For me, Joy-UI is great because it is share high quality underlying implementation with material-ui without obnoxious design of material design. I see that material-ui team is doing now much more (base-ui, mui-x, md v3, zero runtime) I hope that Joy will not get neglected.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 2, 2024

Joy-UI is great because it is share high quality underlying implementation with material-ui without obnoxious design of material design

@chyzwar I'm 💯 aligned with this. I have a friend who uses Joy UI over Material UI because of this. It's also why I would use Joy UI.

Work on Joy UI is right now delayed https://mui.com/blog/2023-material-ui-v6-and-beyond/#a-sharper-focus. This is because of https://npm-stat.com/charts.html?package=%40mui%2Fjoy&from=2022-02-01&to=2024-02-01, there is not enough developer traction relative to its opportunity cost, I think we learned that for Joy UI to work, we need a larger team on it but at the same time we are clearly spread too thin with Material UI, not enough R&D spent on it, it's lagging. Material UI is no longer held back by Material Design as when we started the effort on Joy UI (but helped back by the same things that hold Joy UI back), so we refocused the effort on Material UI to solve these problems. Meaning the judgment call is that right now, there is more ROI on time spent on Material UI than Joy UI.

The good news: we doubled the Core team ~6 months month ago, and are hiring to double this product group again. I suspect this will give us enough bandwidth to cover the scope of Joy UI but this time stand out with more focus and having the main bottlenecks we identified solved.

However, from a developer standpoint, we will likely have Joy UI and Material UI API a lot closer, differentiating with the default look & feel for end-users. I would expect breaking changes.

Speaking under @siriwatknp's control, this is how I understand the situation.

@oliviertassinari oliviertassinari changed the title [data grid] Add Data grid support for Joy UI [data grid] Add support for Joy UI Feb 10, 2024
@kamavingah
Copy link

Adding a link to mui/material-ui#29024 (reply in thread) since it's relevant to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer new feature New feature or request waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

3 participants