-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Maximum Call Stack Size exceeded for createSelectorMemoized
#11483
Comments
Hey @laurisvan ... thanks for raising this. It is indeed a bit strange to see that error. From your description it is not an easy task to determine where to initially look for tbh. @MBilalShafi or @romgrk Could you maybe have a hint or encountered this before? |
createSelectorMemoized
No, we don't have enough information here. We'd need to at least be able to see the code to better assess what's causing it. It would also be nice to have the full stack traces, that could also tell us what's causing it. |
I don't see anything unusual. Next step would be to get a full stack trace, including line numbers, so we can pinpoint where it's going wrong. The interesting data isn't just the last entry, it's the entries leading to the stack overflow. |
Unfortunately I am not able to extract full stack trace, as TrackJS only provides a few traces. As soon as I am able to repeat the problem myself, I could give full information. I am not sure if it gives any more insight, but all the reported browsers are Windows 10 Chromes, with either version 120.0 or 119.0. One of the users confirmed this does not repeat on Edge browser on the same Windows machine. Here's what I am able to give:
|
@mui/xgrid do we have someone with a similar setup (windows 10, chrome v119 or v120 and edge) to test this? |
I could boot in windows 11 to try it. @laurisvan I just noticed that you're on an older version of the grid, could you try the latest 6.x version? |
The issue has been inactive for 7 days and has been automatically closed. If you think that it has been incorrectly closed, please reopen it and provide missing information (if any) or continue the last discussion. |
We just got fresh insight from the problem and actually managed to fix the problem. When checking the problem, we had multiple nested overflowing items (causing multiple nested scrollbars). We anticipated the triple scrollbars were the cause of the problem, and fixed them. As a result, the problem no longer appears. If you are interested, I can try to fish for more information. I believe it is still related to MUI, but not specifically to DataGrid. |
If you find more detailed information you can post here or in the main MUI repository if applicable, but it's also fine to close it and wait until someone has a clear & reproducible case. |
Also facing this after migrating to v7. It happens on a few pages in the app, and there are two places where this error is being thrown Error 1
Error 2 trace
Not able to replicate this yet, as our app serves a lot of settings dynamically in the Datagrid, but this issue has only occured after migrating to v7. I'll try and create a sandbox for this, but I wanted to add this is not resolved. If I should open a new issue for this please let me know I will do so. |
@kavitang Could you provide a reproduction case? https://stackblitz.com/fork/github/mui/mui-x/tree/master/bug-reproductions/x-data-grid |
+1 on this error. It started happening out of the blue today for me. gridFilterSelector.js:27 Uncaught RangeError: Maximum call stack size exceeded From experimenting with it the vertical viewing range of the grid is a factor. Depending on the height grid when the browser is made shorter or taller the error will manifest. If I make the grid smaller the error will show up. If I make the browser taller and the grid expands, the error may not manifest. Once you pass the threshold where the vertical height will need a scroll bar the error will occur. |
@romgrk - It is very hard to create a reproduction of this as the data grid in our app has a lot of dynamic properties. The one area I was able to narrow down here was to remove the setting of the |
We're affected by this issue as well, and it's the sortModel that causes it for us as well. We use both server-side and client-side sorting, depending on different scenarios we have in our product. I see it being a problem only when doing server-side sorting, and only when removing the previously used sorting filter. e.g. This also appears to not happen if we have multiple columns sorting, it happens only when sorting is fully removed (all columns are back to unsorted). Needless to say, it used to work all fine prior to upgrading to v7.3.1. Hope this helps. I can try to provide some snippets if needed. |
The issue has been inactive for 7 days and has been automatically closed. |
Can this be reopened? This is definitely still an issue. |
Yes, this is still an issue, and I have been unable to create a reproduction of this so far. I have had to comment out the sortModel to get this to work. I'll try with the replica sandbox once more over the weekend and update if I'm successful. Please let me know if there is any other specific information I can provide to help debug this in the meanwhile. |
We need more information at the moment. If someone can get us a runnable code example that showcases the exact options you're using, that would help a lot as the options can affect the behavior of the grid substantially so it's hard to debug without that. |
I was able to get rid of the error when I rewrote the |
Reviewing this pointed out to me that we had a bug in that we were sorting based on a field name that didn't exist (typo in the name). Sharing in case that is helpful in adding code protection for that. |
@gaisdav Can you share more details about your setup so we can reproduce the issue and potentially fix it on the Data Grid side? |
I'm unable to reproduce the issue by sorting on the non-existing field: https://stackblitz.com/edit/react-jcxukq?file=Demo.tsx |
@cherniavskii yes, I'll try to do it on Monday. In our project we have a large table with a lot of properties. It won't be that easy. |
Have a try with my repro for #13122 - https://stackblitz.com/edit/github-gbfkio?file=src%2Fdemo.tsx Is this similar to what you're encountering? |
@cherniavskii Hi, I tried yesterday to reproduce the error in an empty project in codesandbox, but I couldn't.
I changed it to
these changes helped me. By the way, I got an error when I changed the page and returned back to the page with the table. I hope that I could help at least a little to understand the problem, although I myself did not fully understand what the problem was 😅 |
Hello , the issue seems to appear when the value of the 'field property doesn't match any of the columns 'field' property values (basically when using a field property value in sortModel that doesn't exist inside the array of columns) |
If that's the case, maybe we should have a quick validation routine at the init to check if referenced columns exist, before any other functionality is triggered? |
I can reproduce the issue with the repro above from @Thinkscape, I'll work on this one next week. |
Duplicates
Steps to reproduce 🕹
Link to live example:
Steps:
Current behavior 😯
Error: Maximum Call Stack Size exceeded
Expected behavior 🤔
No exception
Context 🔦
My sincere apologies that I am not able to provide good steps to repeat, as this problem only repeats on select end users that are non-technical ones. I can only see their blank screens in error reports, and this error in our TrackJS console (screenshot attached) which only tells that it has something to do with memoization calls.
I suspect it might have something to do with memoization of the fields and possible re-renderings. The DataGrids where the problem occurs, do have unique 'field' attributes within the columns, but I suspect there might be multiple DataGrids (having some conflicting field names) alive at the same time.
I am willing to upgrade to the latest MUI if there is even a slightest hint that something related to similar errors have been fixed since @mui/x-data-grid-premium: 6.9.0 (I am aware that there is one Maximum Call Stack Size Exceeded fix in 6.9.1. but I think it is unrelated as it dealt with fractional field widths).
I am willing to hunt for more information and try different things - please kindly give some tips on where to start the hunt.
Your environment 🌎
npx @mui/envinfo
The text was updated successfully, but these errors were encountered: