Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] GridToolbar filters contain duplicate column values when row grouping is enabled #12330

Closed
ewu-larkinc opened this issue Mar 4, 2024 · 3 comments
Labels
component: data grid This is the name of the generic UI component, not the React module!

Comments

@ewu-larkinc
Copy link

ewu-larkinc commented Mar 4, 2024

Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/bold-dawn-3lg5q4

Steps:

  1. Setup DataGrid component with GridToolbar enabled.
  2. Configure initial state using useKeepGroupedColumnsHidden.
  3. Enable row grouping.
  4. Observe that the grouped columns appear twice within the Columns filter dropdown.

Current behavior

Grouped columns appear twice within the filter panel Columns dropdown, even when setting grouped columns to hidden.

Expected behavior

I'd expect useKeepGroupedColumnsHidden to apply to the Columns filter dropdown so that we can avoid listing duplicate column values. Or, at the very least, I'd expect that there be some way of differentiating between the duplicate columns filter values (one of them refers to the original column and the other refers to the grouping, but they are being displayed with the same label).

Context

I'm trying to avoid confusion from any users that would like to apply filtering and are finding that the grouped columns appear twice within the Columns filter dropdown within the filter panel.

Your environment

No response

Search keywords: GridToolbar, filters, duplicate columns

@ewu-larkinc ewu-larkinc added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 4, 2024
@MBilalShafi
Copy link
Member

It seems similar to this one: #12223
Can you check if the solution suggested by @michelengelen could work for you?

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2024
@ewu-larkinc
Copy link
Author

ewu-larkinc commented Mar 11, 2024

That does resolve my issue, thank you!

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Mar 11, 2024
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 12, 2024
Copy link

⚠️ This issue has been closed.
If you have a similar problem, please open a new issue and provide details about your specific problem.
If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @ewu-larkinc?
Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

@michelengelen michelengelen changed the title GridToolbar filters contain duplicate column values when row grouping is enabled [data grid] GridToolbar filters contain duplicate column values when row grouping is enabled Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants