Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts][BarChart] axis categoryGapRatio and barGapRatio gives TS errors #13154

Closed
apdrsn opened this issue May 16, 2024 · 3 comments
Closed
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! typescript

Comments

@apdrsn
Copy link

apdrsn commented May 16, 2024

Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/xenodochial-star-qjthpl (fork from this example https://mui.com/x/react-charts/bars/#bar-direction)

Steps:

  1. I changed the forked package.json to have "latest" instead of "next" for the @mui/material package
  2. Throws a ts error
    image

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: categoryGapRatio barGapRatio
Order ID: 90196

@apdrsn apdrsn added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 16, 2024
@michelengelen michelengelen changed the title BarChart axis categoryGapRatio and barGapRatio gives TS errors [charts][BarChart] axis categoryGapRatio and barGapRatio gives TS errors May 16, 2024
@michelengelen michelengelen added bug 🐛 Something doesn't work typescript component: charts This is the name of the generic UI component, not the React module! labels May 16, 2024
@apdrsn
Copy link
Author

apdrsn commented May 17, 2024

Hi @michelengelen. My colleague just found this issue, which seems to be related. #10334

@michelengelen
Copy link
Member

Hi @michelengelen. My colleague just found this issue, which seems to be related. #10334

Yes and the workaround there is also what I found.
For this to work properly without casting we would probably need to do some typing magic.

@alexfauquette lets track #10334 for the effort and close this one.

@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 17, 2024
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@apdrsn: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

No branches or pull requests

2 participants