Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Fix DateBuilderReturnType when the date is undefined #13244

Merged
merged 2 commits into from
May 27, 2024
Merged

[pickers] Fix DateBuilderReturnType when the date is undefined #13244

merged 2 commits into from
May 27, 2024

Conversation

alexey-kozlenkov
Copy link
Contributor

Fixes #13239

@mui-bot
Copy link

mui-bot commented May 24, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13244--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 47c76d1

flaviendelangle
flaviendelangle approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great improvement!
Thanks for taking care of it

@flaviendelangle flaviendelangle changed the title [pickers] Correct DateBuilderReturnType typing [pickers] Fix DateBuilderReturnType when the date is undefined May 27, 2024
@michelengelen michelengelen added typescript component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels May 27, 2024
@flaviendelangle
Copy link
Member

Not sure why the CI is failing :/

@alexey-kozlenkov
Copy link
Contributor Author

Not sure why the CI is failing :/

Judging by the error it wants me to have a valid License key, however I only made changes under x-date-pickers which is MIT. It happens to me even if I run all tests on my local on next branch (without any changes), I'm not sure how to bypass it :(

@flaviendelangle
Copy link
Member

We recently changed how we generate the fake license for the tests, it's probably related to this change

We'll have a look 👍

@LukasTy
Copy link
Member

LukasTy commented May 27, 2024

@alexey-kozlenkov could you please merge the latest upstream/master to your branch?
It looks like you might have created your branch from a stale fork. 🙈

@alexey-kozlenkov
Copy link
Contributor Author

alexey-kozlenkov commented May 27, 2024 •
edited
Loading

@LukasTy I checked out from next, not master (read this in mui/material), should I rebase on master then and target MR to master too?

UPD: checked other MRs and seems like it, will try

UPD 2: Just for the sake of clarity, there are couple of commits sitting in upstream/next that I picked up when checked out from it and had to drop later when switch direction to master.

@alexey-kozlenkov alexey-kozlenkov force-pushed the fix/adapter-base-fns-date-typing branch from bb57b5e to dde327e Compare May 27, 2024 11:32
@alexey-kozlenkov alexey-kozlenkov changed the base branch from next to master May 27, 2024 11:32
@alexey-kozlenkov alexey-kozlenkov force-pushed the fix/adapter-base-fns-date-typing branch from dde327e to 47c76d1 Compare May 27, 2024 11:34
@michelengelen
Copy link
Member

Looks good now 👍🏼

LukasTy
LukasTy approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍
Thank you for your contribution and a keen eye. 🙏

@LukasTy LukasTy added cherry-pick The PR was cherry-picked from the next branch bug 🐛 Something doesn't work and removed enhancement This is not a bug, nor a new feature labels May 27, 2024
@LukasTy LukasTy merged commit 36381a3 into mui:master May 27, 2024
20 checks passed
@alexey-kozlenkov alexey-kozlenkov deleted the fix/adapter-base-fns-date-typing branch May 27, 2024 12:38
@LukasTy LukasTy added needs cherry-pick The PR should be cherry-picked to master after merge and removed cherry-pick The PR was cherry-picked from the next branch labels May 27, 2024
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request May 28, 2024
@alexey-kozlenkov @LukasTy
[pickers] Fix DateBuilderReturnType when the date is undefined (m…
ea717a8 
…ui#13244)
@LukasTy LukasTy mentioned this pull request May 28, 2024
Closed
@LukasTy LukasTy removed the needs cherry-pick The PR should be cherry-picked to master after merge label May 28, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@alexey-kozlenkov @DungTiger
[pickers] Fix DateBuilderReturnType when the date is undefined (m…
d2d3841 
…ui#13244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@LukasTy LukasTy LukasTy approved these changes

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] DateBuilderReturnType provides wrong type with no arg
5 participants
@alexey-kozlenkov @mui-bot @flaviendelangle @LukasTy @michelengelen