[data grid] Improve localization dx for custom filters #13256
Labels
component: data grid
This is the name of the generic UI component, not the React module!
dx
Related to developers' experience
enhancement
This is not a bug, nor a new feature
feature: Filtering on header
Related to the header filtering (Pro) feature
feature: Filtering
Related to the data grid Filtering feature
l10n
localization
IMHO this is a bad practice:
It crashes even though the
headerLabel
is supposed to be optional.Not sure how we could improve it (wrap in a
try
to avoid crashing and render an empty label? check if the translation key exists before callinggetLocaleText
? Create agetOptionalLocaleText
method?), but right now it's a bad DX.To be clear, this code have been here for ages, it's not a new problem at all, it was already here when I was working on the grid.
Originally posted by @flaviendelangle in #13217 (comment)
Search keywords:
The text was updated successfully, but these errors were encountered: