Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Skeleton Loading Overlay Logs Warnings about Missing Keys in a List #14060

Open
1 task done
4everTonyStark opened this issue Jul 31, 2024 · 3 comments
Open
1 task done
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information

Comments

@4everTonyStark
Copy link

4everTonyStark commented Jul 31, 2024

Latest version

  • I have tested the latest version

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-xiddaf?file=Demo.tsx

Steps:

  1. Open the demo.
  2. Open the console to see the warning.

Current behavior

When the DataGrid's Skeleton Loading Overlay renders for the first time, a warning is logged that all children in a list should have a unique "key" prop.

Expected behavior

No warnings should be logged.

Context

No response

Your environment

npx @mui/envinfo
  System:
    OS: macOS 14.5
  Binaries:
    Node: 20.11.1 - ~/Library/Caches/fnm_multishells/173_1722440156564/bin/node
    npm: 10.2.4 - ~/Library/Caches/fnm_multishells/173_1722440156564/bin/npm
    pnpm: 9.6.0 - ~/Library/Caches/fnm_multishells/173_1722440156564/bin/pnpm
  Browsers:
    Chrome: 127.0.6533.73
    Edge: Not Found
    Safari: 17.5

Chrome is the browser I see the warnings in. I have not tested on Safari.

Search keywords: datagrid skeleton loading overlay

@4everTonyStark 4everTonyStark added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 31, 2024
@github-actions github-actions bot added the component: data grid This is the name of the generic UI component, not the React module! label Jul 31, 2024
@michelengelen
Copy link
Member

Hey @4everTonyStark

I am not able to reproduce this with the link you added.
Could you re-check and update the sandbox if it reappears?

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 1, 2024
@michelengelen michelengelen changed the title DataGrid Skeleton Loading Overlay Logs Warnings about Missing Keys in a List [data grid] Skeleton Loading Overlay Logs Warnings about Missing Keys in a List Aug 1, 2024
@4everTonyStark
Copy link
Author

Hi @michelengelen -

I've tested the link I added more thoroughly. While I do not see any errors logged on my iPhone's Safari browser, I do see the errors logged on Chrome, Firefox, and Safari on my Mac. I'm not sure why it appears as a plain console.log() output in the StackBlitz, as React prints it as an error when I run the demo files in my IDE locally.

Chrome:
image
Safari:
image
Firefox:
image

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Aug 2, 2024
@michelengelen
Copy link
Member

I am still not able to reproduce from either of the mentioned browsers (Screenshots below).
Did you do anything other than just loading it?
Screenshot 2024-08-02 at 11 02 14
Screenshot 2024-08-02 at 11 02 22
Screenshot 2024-08-02 at 11 03 52

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

2 participants