Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Match <Table> styles, hide column separator #1623

Closed
2 tasks done
oliviertassinari opened this issue May 11, 2021 · 0 comments 路 Fixed by #7067
Closed
2 tasks done

[DataGrid] Match <Table> styles, hide column separator #1623

oliviertassinari opened this issue May 11, 2021 · 0 comments 路 Fixed by #7067
Labels
component: data grid This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer v6.x

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 11, 2021 •
edited

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 馃槸

A column header separator is visible.

Expected Behavior 馃

No column header separator.

Steps to Reproduce 馃暪

Steps:

  1. Open https://material-ui.com/components/data-grid/#mit-version

Screenshot 2021-05-11 at 11 20 58

Context 馃敠

It doesn't match https://mui.com/material-ui/react-table/ nor https://material.io/components/data-tables. This was spotted looking into adding coverage for the data grid in the Figma kit.

Regarding the affordance of the column resize feature, I would encourage us to show a separator on hover, so it's clear for the end-users that they can resize with DataGridPro but can't in DataGrid, it's misleading otherwise (or maybe it was done to encourage developers to upgrade to the pro plan 馃檲).

Your Environment 馃寧

v4.0.0-alpha.28
@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels May 11, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Match Table styles [DataGrid] Match <Table> styles May 11, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Match <Table> styles [DataGrid] Match <Table> styles, hide column separator May 17, 2021
@oliviertassinari oliviertassinari mentioned this issue Jan 19, 2022
Closed
2 tasks
@gerdadesign gerdadesign mentioned this issue Jun 16, 2022
Merged
13 tasks
@m4theushw m4theushw mentioned this issue Aug 16, 2022
Open
2 tasks
@MBilalShafi MBilalShafi mentioned this issue Dec 2, 2022
Merged
2 tasks
@oliviertassinari oliviertassinari mentioned this issue May 30, 2023
Open
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove column separator to match table styles MBilalShafi/mui-x
2 participants
@joserodolfofreitas @oliviertassinari